Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order modules and re-name data types #265

Merged
merged 34 commits into from
Aug 9, 2024
Merged

Re-order modules and re-name data types #265

merged 34 commits into from
Aug 9, 2024

Conversation

dr-orlovsky
Copy link
Member

Pure chore: just type renames and tossing them across the modules.

Since after #263 meaning of many data types has changed, this re-naming ensures the names remain consistent to the type semantics.

Moving types around modules is required to ensure proper module abstractions: schema -> operation -> vm -> validation, where module on the left doesn't know anything (or imports anything) about the module on the right

@dr-orlovsky dr-orlovsky added the refactoring Code refactoring label Jul 30, 2024
@dr-orlovsky dr-orlovsky force-pushed the movearound branch 3 times, most recently from 1a08fb0 to 6a6d2a3 Compare July 30, 2024 17:35
@dr-orlovsky dr-orlovsky marked this pull request as ready for review August 9, 2024 13:09
@dr-orlovsky dr-orlovsky merged commit 8af3baf into master Aug 9, 2024
19 of 20 checks passed
@dr-orlovsky dr-orlovsky deleted the movearound branch September 4, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant