Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning similar work: datastorr, fst, etc. #21

Closed
wlandau opened this issue Jul 1, 2018 · 3 comments
Closed

Mentioning similar work: datastorr, fst, etc. #21

wlandau opened this issue Jul 1, 2018 · 3 comments

Comments

@wlandau
Copy link
Member

wlandau commented Jul 1, 2018

Hi @gfinak,

I am reviewing DataPackageR for ropensci/software-review#230, and I have decided to create separate issues for my comments so we can discuss more easily. Once I have posted all my comments, I will submit my formal review to ropensci/software-review#230, which will cross reference them. I recommend creating a custom label to keep track of these issues.

Anyway, as mentioned in this thread from the 2018 Unconference, @noamross has a slide deck in which he describes existing work on data packaging, such as datastorr and fst. Would you consider adding a section to the README that points to this existing work and emphasizes the strengths of DataPackageR in this landscape?

@gfinak
Copy link
Member

gfinak commented Jul 2, 2018

@wlandau, happy to do it. Thanks for pointing these out as well, I was not aware of them. I think they can be quite complementary with DataPackageR.

@gfinak
Copy link
Member

gfinak commented Jul 2, 2018

@wlandau thanks for the review and the suggestions, I look forward to addressing and implementing these changes, I think they'll make the package significantly better.

@wlandau
Copy link
Member Author

wlandau commented Jul 6, 2018

Glad this is helpful. Your new "Similar work" section is great.

@wlandau wlandau closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants