Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation in ?DataPackageR-package is out of date with the README #29

Closed
wlandau opened this issue Jul 2, 2018 · 1 comment
Closed

Documentation in ?DataPackageR-package is out of date with the README #29

wlandau opened this issue Jul 2, 2018 · 1 comment
Labels
Ropensci issues

Comments

@wlandau
Copy link
Member

wlandau commented Jul 2, 2018

From ?DataPackageR-package:

The 'datasets.R' file and files it sources are expected to read raw data from 'inst/extdata', or other sources...

From https://github.com/RGLab/DataPackageR#partial-builds-and-migrating-old-data-packages:

Version 1.12.0 has moved away from controlling the build process using datasets.R and an additional masterfile argument.
@wlandau wlandau mentioned this issue Jul 2, 2018
Closed
19 tasks
gfinak added a commit that referenced this issue Jul 2, 2018
@gfinak
Add examples #27
be02a74 
Update DataPackageR-package documentation for #29 to reflect the new changes with yaml.
- examples for build_package
- datapackage_skeleton
- data_version
- fix minor bug in datapackage_skeleton so that files are overwritten during copy.
gfinak added a commit that referenced this issue Jul 5, 2018
@gfinak
This commit and previous should address remaining ropensci reviewer i…
691e8e4 
…ssues.

#21 #22 #23 #24 #25 #26 #27 #28 #29 #30 #31 #32
@wlandau
Copy link
Member Author

wlandau commented Jul 6, 2018

?DataPackageR-package looks completely rewritten. I did not catch automatic vignette creation before. Such a great feature.

The Rmd and R files used to process the objects are transformed
into vignettes accessible in the final package so that the
processing is fully documented.

@wlandau wlandau closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ropensci issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfinak @wlandau