Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(route53): optimize hosted zones retrieval #130

Open
wants to merge 1 commit into
base: release-0.4
Choose a base branch
from
Open

feat(route53): optimize hosted zones retrieval #130

wants to merge 1 commit into from

Conversation

vbelouso
Copy link
Collaborator

@vbelouso vbelouso commented Feb 5, 2025

  • Replace multiple AWS API calls with single bulk load
  • Load all hosted zones tags once into memory
  • Improve naming conventions for Route53 methods

This change reduces API calls and improves performance when looking up cluster console URLs.

@vbelouso vbelouso requested a review from r2dedios February 5, 2025 12:25
@vbelouso vbelouso self-assigned this Feb 5, 2025
@vbelouso vbelouso added the enhancement New feature or request label Feb 5, 2025
@vbelouso vbelouso added this to the v0.4 milestone Feb 5, 2025
@vbelouso vbelouso marked this pull request as draft February 5, 2025 12:26
@vbelouso
feat(route53): optimize hosted zones retrieval
dab7dfc 
Signed-off-by: Vladimir Belousov <vbelouso@redhat.com>
@vbelouso vbelouso marked this pull request as ready for review February 12, 2025 06:43
r2dedios
r2dedios approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@r2dedios r2dedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the performance improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r2dedios r2dedios r2dedios approved these changes

Assignees

@vbelouso vbelouso

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@vbelouso @r2dedios