Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/pkg_c25519: increase timeout on non-native #11347

Merged
merged 1 commit into from
Apr 5, 2019
Merged

tests/pkg_c25519: increase timeout on non-native #11347

merged 1 commit into from
Apr 5, 2019

Conversation

bergzand
Copy link
Member

@bergzand bergzand commented Apr 5, 2019

Contribution description

Nightly CI was failing on this test as it takes around 13-14 seconds on a samr21-xpro. Increased to 20 seconds to give it some margin.

Testing procedure

Checking the code and checking the CI status should be enough

Issues/PRs references

The nightly output

@bergzand bergzand added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Apr 5, 2019
@bergzand bergzand requested review from miri64 and kaspar030 April 5, 2019 14:36
miri64
miri64 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, when murdock passes on this one.

@kaspar030
Copy link
Contributor

seeing the test result cache in action.

@miri64 miri64 merged commit 2ef1451 into RIOT-OS:master Apr 5, 2019
@miri64
Copy link
Member

miri64 commented Apr 5, 2019

Please backport.

@bergzand bergzand mentioned this pull request Apr 5, 2019
Merged
@bergzand
Copy link
Member Author

bergzand commented Apr 5, 2019

Backport provided in #11348

@miri64 miri64 added this to the Release 2019.04 milestone Apr 11, 2019
@danpetry danpetry removed this from the Release 2019.04 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bergzand @kaspar030 @miri64 @danpetry