Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/auto_init/can: cleanup for STM32 CAN controller driver #11991

Merged
merged 1 commit into from
Aug 19, 2019
Merged

sys/auto_init/can: cleanup for STM32 CAN controller driver #11991

merged 1 commit into from
Aug 19, 2019

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR removes the initialization code for the can_stm32 module. The initialization became obsolete with PR #6178 because the STM32 CAN controller driver is no longer a module.

Testing procedure

Compilation of application tests/conn_can for a STM32 board which provides periph_can feature has to be successful:

make BOARD=nucleo-f413zh -C tests/conn_can/

Issues/PRs references

Related to PR #6178

@gschorcht
sys/auto_init/can: cleanup for STM32 CAN controller
ba00269 
Initialization code for module `can_stm32` is obsolete since the STM32 CAN controller driver isn't a module anymore.
@gschorcht gschorcht requested a review from vincent-d August 9, 2019 16:29
@gschorcht gschorcht added Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Aug 9, 2019
vincent-d
vincent-d approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@vincent-d vincent-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. This was dead code, checked with git grep, module can_stm32 and function auto_init_can_stm32() do not exist.

@vincent-d vincent-d merged commit 5a953a2 into RIOT-OS:master Aug 19, 2019
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
@gschorcht gschorcht deleted the cpu/stp32_common/can/auto-init-cleanup branch October 19, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-d vincent-d vincent-d approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @vincent-d @kb2ma