Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kconfig: Expose gnrc/lorawan configurations #12923

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Kconfig: Expose gnrc/lorawan configurations #12923

merged 2 commits into from
Dec 20, 2019

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This PR changes the timer drift configuration for LoRaWAN to be expressed in per mille, instead of percentage. So now setting it to 1 means 0.1% drift correction. It also exposes GNRC LoRaWAN's configurations to Kconfig.

Testing procedure

  • gnrc_lorawan example application should work as usual.
  • You should be able to configure GNRC LoRaWAN running make menuconfig in that application.

Issues/PRs references

Part of #12888

@leandrolanzieri leandrolanzieri added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force labels Dec 11, 2019
@leandrolanzieri leandrolanzieri added this to the Release 2020.01 milestone Dec 11, 2019
@leandrolanzieri leandrolanzieri mentioned this pull request Dec 11, 2019
Open
71 tasks
@fjmolinas
Copy link
Contributor

ping @jia200x!

@jia200x
Copy link
Member

jia200x commented Dec 18, 2019

I will give it a look

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig_migrate/gnrc/lorawan branch from fce8fd9 to 82c2722 Compare December 20, 2019 10:44
@jia200x
Copy link
Member

jia200x commented Dec 20, 2019

I added a small suggestion. Besides that, this looks good and works as expected (and the range of GNRC_LORAWAN_TIMER_DRIFT is fine)

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig_migrate/gnrc/lorawan branch from 82c2722 to b58b579 Compare December 20, 2019 13:15
@jia200x
Copy link
Member

jia200x commented Dec 20, 2019

ok, good! Thanks

jia200x
jia200x approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x
Copy link
Member

jia200x commented Dec 20, 2019

let's wait for Murdock and then go

@leandrolanzieri leandrolanzieri merged commit b00ad30 into RIOT-OS:master Dec 20, 2019
@leandrolanzieri leandrolanzieri deleted the pr/kconfig_migrate/gnrc/lorawan branch December 20, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @fjmolinas @jia200x