-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kconfig: Expose net/sock/util configurations #12944
Kconfig: Expose net/sock/util configurations #12944
Conversation
Macros that changed: SOCK_SCHEME_MAXLEN -> CONFIG_SOCK_SCHEME_MAXLEN SOCK_HOSTPORT_MAXLEN -> CONFIG_SOCK_HOSTPORT_MAXLEN SOCK_URLPATH_MAXLEN -> CONFIG_SOCK_URLPATH_MAXLEN
@leandrolanzieri I haven't used kconfig much yet, how do I enable it for the module? :) |
In an application that uses the module (e.g. |
I had done that but didn't specify the BOARD when reunning menuconfig, which is why I didn't see the changes at first, may bad, works as expected.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK!
@fjmolinas thanks for testing and reviewing ! |
Contribution description
This PR moves configuration macros of SOCK utilities module to the
CONFIG_
namespace. It also exposes them to Kconfig.Testing procedure
You can check the values in some application that uses this module (e.g.
examples/gcoap
). Make sure configurations take the default values as usual from the header files. Runmake menuconfig
, enable the configuration of the module and change the values.You can use this patch:
Issues/PRs references
Part of #12888