Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/coap: deprecate gcoap_add_qstring() and update uses #13240

Merged
merged 2 commits into from
Mar 13, 2020
Merged

net/coap: deprecate gcoap_add_qstring() and update uses #13240

merged 2 commits into from
Mar 13, 2020

Conversation

kb2ma
Copy link
Member

@kb2ma kb2ma commented Jan 30, 2020

Contribution description

#13213 added the function coap_opt_add_uquery() to the nanocoap Packet API as part of the effort to move this API to nanocoap. This PR follows up on that work to deprecate the gcoap function, gcoap_add_qstring(), and update uses of the gcoap function to the new nanocoap function.

gcoap_add_qstring() will not be available after the 2020.10 release.

Testing procedure

Build the documentation and verify the deprecation notice. Verify that the cord_ep example registers to an RD server as expected.

Issues/PRs references

Final step for #9309

@kb2ma kb2ma added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: CoAP Area: Constrained Application Protocol implementations labels Jan 30, 2020
@kb2ma kb2ma added this to the Release 2020.04 milestone Jan 30, 2020
leandrolanzieri
leandrolanzieri approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Documentation is OK and the cord_ep example still works as expected.

main(): This is RIOT! (Version: 2020.04-devel-166-g7f3e9-gcoap/deprecate_add_qstring)
CoRE RD client example!

Client information:
  ep: RIOT-883E2323883E2323
  lt: 60s
> cord_ep register [fe80::c90:6aff:fee8:b57d] 
cord_ep register [fe80::c90:6aff:fee8:b57d]
Registering with RD now, this may take a short while...
RD endpoint event: now registered with a RD
registration successful

CoAP RD connection status:
RD address: coap://[fe80::c90:6aff:fee8:b57d]:5683
   ep name: RIOT-883E2323883E2323
  lifetime: 60s
    reg if: /resourcedirectory
  location: /reg/2/
>

ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 13, 2020
@kb2ma kb2ma merged commit ec2aff4 into RIOT-OS:master Mar 13, 2020
@kb2ma
Copy link
Member Author

kb2ma commented Mar 13, 2020

Thanks, @leandrolanzieri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
2 participants
@kb2ma @leandrolanzieri