-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/conn_can: fix build error on native #13270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wosym
changed the title
tests/conn_can: add conditional for building on native
tests/conn_can: fix build error on native
Feb 3, 2020
kaspar030
requested changes
Feb 3, 2020
wosym
force-pushed
the
conn_cann_native
branch
2 times, most recently
from
February 3, 2020 12:55
28a060c
to
0250851
Compare
benpicco
added
Area: tests
Area: tests and testing framework
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Feb 3, 2020
wosym
force-pushed
the
conn_cann_native
branch
3 times, most recently
from
February 7, 2020 10:01
98aa257
to
940ded3
Compare
wosym
force-pushed
the
conn_cann_native
branch
from
February 7, 2020 12:35
940ded3
to
ae947d5
Compare
Any update on this @kaspar030? |
benpicco
reviewed
Feb 20, 2020
vincent-d
reviewed
Feb 20, 2020
vincent-d
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. ACK
ping @kaspar030 |
@kaspar030 Still want something changed? :) |
kaspar030
approved these changes
Feb 24, 2020
Nope, all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When building tests/conn_can for native, it would fail because of unsatisfied feature requirements:
Adding an extra check for BOARD=native solves this problem.Remove these feature requirements all together, since they are not needed here (see conversation below).
update 7/02:
Testing procedure