Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/conn_can: fix build error on native #13270

Merged
merged 4 commits into from
Feb 24, 2020

Conversation

wosym
Copy link
Member

@wosym wosym commented Feb 3, 2020

Contribution description

When building tests/conn_can for native, it would fail because of unsatisfied feature requirements:

There are unsatisfied feature requirements: periph_can periph_gpio_irq

Adding an extra check for BOARD=native solves this problem.
Remove these feature requirements all together, since they are not needed here (see conversation below).
update 7/02:

  • CI brought some ancient mistakes to our attention. Fixed these also up in a seperate commit.
  • Removing "FEATURES_REQUIRED" loosened the restriction on boards that should support this test. However, not all boards have sufficient memory --> updated the BOARDS_INSUFFICIENT_MEMORY list.
  • add arch_msp430 to FEATURES_BLACKLIST

Testing procedure

  • Build on native before patch --> fail
  • Build on native after patch --> success

@wosym wosym changed the title tests/conn_can: add conditional for building on native tests/conn_can: fix build error on native Feb 3, 2020
tests/conn_can/Makefile Outdated Show resolved Hide resolved
@wosym wosym force-pushed the conn_cann_native branch 2 times, most recently from 28a060c to 0250851 Compare February 3, 2020 12:55
@benpicco benpicco added Area: tests Area: tests and testing framework Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 3, 2020
@wosym wosym force-pushed the conn_cann_native branch 3 times, most recently from 98aa257 to 940ded3 Compare February 7, 2020 10:01
@wosym wosym requested a review from kaspar030 February 7, 2020 14:39
@wosym
Copy link
Member Author

wosym commented Feb 17, 2020

Any update on this @kaspar030?

Copy link
Member

@vincent-d vincent-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK

@vincent-d
Copy link
Member

ping @kaspar030

@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 21, 2020
@wosym
Copy link
Member Author

wosym commented Feb 24, 2020

@kaspar030 Still want something changed? :)

@kaspar030
Copy link
Contributor

Nope, all good!

@kaspar030 kaspar030 merged commit 1e74280 into RIOT-OS:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants