drivers/mrf24j40: Expose configurations to Kconfig #13314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrolanzieri
added
Type: new feature
71 tasks
leandrolanzieri
force-pushed
the
pr/kconfig_migrate/drivers/mrf24j40
branch
from
4646fc2 to
bb56b50
Compare
cyrilfr
reviewed
Feb 10, 2020
leandrolanzieri
requested review from
aabadie,
bergzand,
cgundogan and
fjmolinas
as code owners
|
@jia200x @bergzand @fjmolinas any feedback to converge this? |
|
ok, I tested both configuration options:
The examples still compile fine, so I would say this PR is in shape |
|
@leandrolanzieri please squash |
MRF24J40_TEST_SPI_CONNECTION is moved to the 'CONFIG_' namespace and by default is not set. Now it is checked in code using 'IS_ACTIVE'.
MRF24J40_USE_EXT_PA_LNA is moved to the 'CONFIG_' namespace and by default is not set. Now it is checked in code using 'IS_ACTIVE'.
For the mrf24j40 check if Kconfig is being used before setting the configuration CFLAG.
leandrolanzieri
force-pushed
the
pr/kconfig_migrate/drivers/mrf24j40
branch
from
e185f41 to
6e49724
Compare
|
@jia200x squashed |
|
let's wait for Murdock and travis |
jia200x
added
the
CI: ready for build
|
all right, let's go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes the configurations of the
mrf24j40radio driver to Kconfig. The usage of the options were modified to match the behaviour of Kconfig, soIS_ACTIVEis being used now.I am setting
MRF24J40_USE_EXT_PA_LNAto default y because that's the observed behaviour fromdrivers/Makefile.dep.Testing procedure
gnrc_networkingand using somemrf24j40module should be working.mrj24j40mais usedMRF24J40_USE_EXT_PA_LNAis not available.Issues/PRs references
Part of #12888