xtimer: properly expose xtimer_usleep64() #13370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Type: enhancement
kaspar030
approved these changes
Feb 13, 2020
This was referenced Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
xtimer_usleep64()is currently implemented (seesys/include/xtimer/implementation.h), but not properly exposed in the actual xtimer API (sys/include/xtimer.h). Although the function was callable and usable before, this PR prevents any future (internal) xtimer changes from braking code that uses this function. Also having it documented does probably not hurt...Testing procedure
xtimer_usleep64()withtimeout > UINT32_MAXin any example and wait for > 1,19 hours, the blocked thread should continue properly after the specified timeout...Issues/PRs references
see apache/mynewt-nimble#753