Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtimer: add xtimer_set_timeout_flag64() #13371

Merged
merged 2 commits into from
Feb 13, 2020
Merged

xtimer: add xtimer_set_timeout_flag64() #13371

merged 2 commits into from
Feb 13, 2020

Conversation

haukepetersen
Copy link
Contributor

Contribution description

This PR adds xtimer_set_timeout_flag64() to xtimer. In the same style as we already have e.g. set_msg() and set_msg64(), there are some use cases that need to set the timeout flag with a timeout greater UINT32_MAX. IMHO this also adds to the APIs consistency of having both 32-bit and 64-bit variants of functions.

This PR also adds a call to xtimer_set_timeout_flag64 to the tests/thread_flags test application.

Testing procedure

Run tests/thread_flags and check doxygen.

Issues/PRs references

apache/mynewt-nimble#753

@haukepetersen haukepetersen changed the title Add xtimer settimeoutflag64 xtimer: add xtimer_set_timeout_flag64() Feb 13, 2020
@haukepetersen haukepetersen added Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Feb 13, 2020
kaspar030
kaspar030 approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward addition. ACK.

@haukepetersen haukepetersen mentioned this pull request Feb 13, 2020
Merged
@kaspar030 kaspar030 merged commit fc40b54 into RIOT-OS:master Feb 13, 2020
@haukepetersen haukepetersen deleted the add_xtimer_settimeoutflag64 branch February 13, 2020 15:18
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@haukepetersen @kaspar030 @leandrolanzieri