-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc/ipv6/nib: Expose configurations to Kconfig #13626
gnrc/ipv6/nib: Expose configurations to Kconfig #13626
Conversation
@leandrolanzieri please rebase. |
63cb8a1
to
a68bb55
Compare
I wrapped lines to 80 chars on files where I was getting the 100 char warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly style and documentation stuff, as this is just renaming the macros and introduces the Kconfig file. Everything else should be uncovered by Murdock. Please squash immediately. I can't keep track of >20 commits anyways ;-P
3df65ce
to
aa8319e
Compare
@miri64 I think I addressed all comments. I squashed directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor error picked up by Murdock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are fixing this anyway: how about some more warnings about experimental options.
Also evaluate it using IS_ACTIVE macro.
Also evaluate it using IS_ACTIVE
Also evaluate it using IS_ACTIVE macro.
Also evaluate it using IS_ACTIVE macro.
Also evaluate it using IS_ACTIVE macro.
Also evaluate it using IS_ACTIVE macro.
Also evaluate it using IS_ACTIVE macro.
Also evaluate using IS_ACTIVE macro.
Also evaluate using IS_ACTIVE macro.
Also evaluate using IS_ACTIVE macro.
Also evaluate using IS_ACTIVE macro.
Also evaluate using IS_ACTIVE macro.
Also evaluate using IS_ACTIVE macro.
aa8319e
to
5833a3f
Compare
Added a fixup to guard all configuration parameters from the header when using Kconfig, so it does not override booleans. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with native
and samr21-xpro
:
examples/gcoap
to test hosts (standard withnative
and 6LN withsamr21-xpro
)examples/gnrc_networking
to test routers (standard withnative
and 6LR withsamr21-xpro
)examples/gnrc_border_router
to test 6LBRs
Then I pinged both link-local addresses and global addresses. I did this without Kconfig and with Kconfig. To check the configuration with Kconfig, I deactivated router solicitations with examples/gcoap
using CONFIG_GNRC_IPV6_NIB_NO_RTR_SOL=1
(which flashed the nice new warning).
It all worked. With the changed configuration the gcoap example did not send any router solicitation (making the global ping impossible on the samr21-xpro
, as was expected).
ACK. Please squash your final change.
f9b33d4
to
aa2ec68
Compare
🎉 |
Contribution description
This PR moves configuration macros of GNRC NIB module to the
CONFIG_
namespace and exposes them to Kconfig. To keep compatibility with boolean macros generated by Kconfig I modified the evaluation of many of them usingIS_ACTIVE
.I think there are some cases where the
#if
could be changed to C conditionals, but as I was not so sure I decided not to change this in general.Testing procedure
Issues/PRs references
Part of #12888