Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/nanocoap: remove obsolete functions for addition of Uri-Query option #13829

Merged
merged 1 commit into from
Apr 8, 2020
Merged

net/nanocoap: remove obsolete functions for addition of Uri-Query option #13829

merged 1 commit into from
Apr 8, 2020

Conversation

kb2ma
Copy link
Member

@kb2ma kb2ma commented Apr 7, 2020

Contribution description

Early in the 2020.04 release cycle #13213 and #13022 introduced coap_opt_add_uquery() and coap_opt_add_uquery2() to add a Uri-Query option with the Packet API. Earlier today #13815 was merged to add coap_opt_add_uri_query() and coap_opt_add_uri_query2() to replace them. This PR removes the obsolete function names before the 2020.04 release so we don't need to deprecate them.

Testing procedure

Run nanocoap unit tests. Verify no uses of coap_opt_add_uquery() or coap_opt_add_uquery2() in code base.

Issues/PRs references

See above.

@kb2ma kb2ma added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: CoAP Area: Constrained Application Protocol implementations labels Apr 7, 2020
@kb2ma kb2ma added this to the Release 2020.04 milestone Apr 7, 2020
@kb2ma kb2ma added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 7, 2020
@kb2ma kb2ma requested review from pokgak and miri64 April 7, 2020 16:30
pokgak
pokgak approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@pokgak pokgak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nanocoap unittests runs fine, no reference to coap_opt_add_uquery() or coap_opt_add_uquery2 found. LGTM.

@pokgak
Copy link
Contributor

pokgak commented Apr 7, 2020

Murdock error looks weird...

@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 7, 2020
leandrolanzieri
leandrolanzieri approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup looks good. ACK.

@leandrolanzieri leandrolanzieri merged commit 56dc53a into RIOT-OS:master Apr 8, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Apr 8, 2020
@kb2ma
Copy link
Member Author

kb2ma commented Apr 8, 2020

Thanks, @leandrolanzieri, and good luck with the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@pokgak pokgak pokgak approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
4 participants
@kb2ma @pokgak @leandrolanzieri @cgundogan