-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/gcoap: add CoAP ping request #13894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kb2ma
requested review from
cgundogan,
haukepetersen,
miri64 and
PeterKietzmann
as code owners
April 17, 2020 16:40
kb2ma
added
Area: CoAP
Area: Constrained Application Protocol implementations
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
labels
Apr 17, 2020
leandrolanzieri
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Apr 21, 2020
leandrolanzieri
added
Reviewed: 1-fundamentals
The fundamentals of the PR were reviewed according to the maintainer guidelines
Reviewed: 3-testing
The PR was tested according to the maintainer guidelines
labels
Apr 21, 2020
leandrolanzieri
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and functionality works as expected. ACK.
Nice feature!
leandrolanzieri
added
Reviewed: 2-code-design
The code design of the PR was reviewed according to the maintainer guidelines
Reviewed: 4-code-style
The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines
Reviewed: 5-documentation
The documentation details of the PR were reviewed according to the maintainer guidelines
labels
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: CoAP
Area: Constrained Application Protocol implementations
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Reviewed: 1-fundamentals
The fundamentals of the PR were reviewed according to the maintainer guidelines
Reviewed: 2-code-design
The code design of the PR was reviewed according to the maintainer guidelines
Reviewed: 3-testing
The PR was tested according to the maintainer guidelines
Reviewed: 4-code-style
The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines
Reviewed: 5-documentation
The documentation details of the PR were reviewed according to the maintainer guidelines
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Presently gcoap supports use of a piggybacked ACK response to a confirmable request. However, #13637 illustrated the need to support separate confirmable responses, as also identified in the tracking issue #7192. A prerequisite for this support is the ability to handle empty messages, which is the format for the immediate ACK response. This PR takes the first step toward empty message support by addition of handling for CoAP ping requests.
Specifically, this PR allows creation of a ping request (empty CON with code 0.00) and generation of a reset response (empty RST also with code 0.00). This PR does not include handling for the reset response because that requires empty message support for request/response correlation, which will follow in a separate PR.
gcoap_req_init()
to generate ping request if code is 0.00, including unit testTesting procedure
gcoap_req_init()
Issues/PRs references
See above.