Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/cc110x : Expose Configurations to Kconfig #13897

Merged
merged 2 commits into from
Apr 20, 2020
Merged

drivers/cc110x : Expose Configurations to Kconfig #13897

merged 2 commits into from
Apr 20, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 17, 2020 •
edited
Loading

Contribution description

This PR exposes compile configurations in CC110X Network Device driver to Kconfig.

Testing procedure

The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.

Default State:

Firmware Output

magnrc_netif: netdev init failed: -134
rc_netif: netdev init failed: -134
07-devel-97-g01a8c6-Kconfig_cc110x)
CONFIG_CC110X_DEFAULT_CHANNEL=(0U)
cc110x driver test application
..................

Usage with CFLAGS

/tests/driver_ads101x/Makefile

CFLAGS += -DCONFIG_CC110X_DEFAULT_CHANNEL=3

Firmware Output

magnrc_netif: netdev init failed: -134
rc_netif: netdev init failed: -134
07-devel-97-g01a8c6-Kconfig_cc110x)
CONFIG_CC110X_DEFAULT_CHANNEL=3
cc110x driver test application
..................

Usage with Kconfig

/tests/cc110x/

make menuconfig

Firmware Output

magnrc_netif: netdev init failed: -134
rc_netif: netdev init failed: -134
07-devel-97-g01a8c6-Kconfig_cc110x)
CONFIG_CC110X_DEFAULT_CHANNEL=7
cc110x driver test application
..................

Note : The network device is not available fro interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

akshaim added 2 commits April 17, 2020 23:27
@akshaim
drivers/cc110x : Add CONFIG_
01a8c64 
Add Add CONFIG_ Prefix for CC110X_DEFAULT_CHANNEL
@akshaim
drivers/cc110x : Expose to Kconfig
be097f8 
Expose Configurations to Kconfig
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 18, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 18, 2020
leandrolanzieri
leandrolanzieri approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The configuration macro is generated correctly from Kconfig. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 20, 2020
@leandrolanzieri leandrolanzieri merged commit d8fa69d into RIOT-OS:master Apr 20, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 20, 2020
Open
71 tasks
@akshaim akshaim deleted the Kconfig_cc110x branch May 4, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@maribu maribu Awaiting requested review from maribu maribu is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri