Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/dose.h : Expose Configurations to Kconfig #13910

Merged
merged 2 commits into from
Apr 22, 2020
Merged

drivers/dose.h : Expose Configurations to Kconfig #13910

merged 2 commits into from
Apr 22, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 20, 2020 •
edited
Loading

Contribution description

This PR exposes compile configurations in Dose network driver to Kconfig.

Testing procedure

The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.

New macro was introduced in main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-97-ga0d15-Kconfig_dose)
CONFIG_DOSE_TIMEOUT_USEC=(5000)

Usage with CFLAGS

/tests/driver_dose/Makefile

CFLAGS += -DCONFIG_DOSE_TIMEOUT_USEC=6500

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-97-ga0d15-Kconfig_dose)
CONFIG_DOSE_TIMEOUT_USEC=6500

Usage with Kconfig

/tests/driver_dose/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-97-ga0d15-Kconfig_dose)
CONFIG_DOSE_TIMEOUT_USEC=10000

Note : The sensor is not available hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

@leandrolanzieri leandrolanzieri mentioned this pull request Apr 20, 2020
Open
71 tasks
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 20, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 20, 2020
leandrolanzieri
leandrolanzieri reviewed Apr 20, 2020
View reviewed changes
drivers/dose/Kconfig Outdated Show resolved Hide resolved
drivers/dose/Kconfig Outdated Show resolved Hide resolved
@leandrolanzieri
Copy link
Contributor

Please rebase

@leandrolanzieri leandrolanzieri self-assigned this Apr 20, 2020
@akshaim
Copy link
Member Author

akshaim commented Apr 21, 2020

Please rebase

Done

@leandrolanzieri
Copy link
Contributor

Looks good, please squash

akshaim and others added 2 commits April 21, 2020 16:00
@akshaim
drivers/dose : Add CONFIG_
0784190 
Add CONFIG_ Prefix for DOSE_TIMEOUT_USEC
@akshaim @leandrolanzieri
drivers/dose : Expose to Kconfig
3a65d16 
Expose Configurations to Kconfig

Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 22, 2020
leandrolanzieri
leandrolanzieri approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 22, 2020
@leandrolanzieri leandrolanzieri merged commit 7284434 into RIOT-OS:master Apr 22, 2020
@akshaim akshaim deleted the Kconfig_dose branch April 22, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

@leandrolanzieri leandrolanzieri

Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaim @leandrolanzieri @kaspar030