Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/mma8x5x : Expose Configurations to Kconfig #13926

Merged
merged 2 commits into from
Apr 23, 2020
Merged

drivers/mma8x5x : Expose Configurations to Kconfig #13926

merged 2 commits into from
Apr 23, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 22, 2020 •
edited
Loading

Contribution description

This PR exposes compile configurations in MMA8X5X Sensor Device driver to Kconfig.

Testing procedure

The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.

New macro was introduced in main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-159-ge836e-Kconfig_mma8x5x)
CONFIG_MMA8X5X_I2C_ADDRESS=0x1D
MMA8652 accelerometer driver test application

Initializing MMA8652 accelerometer at I2C_DEV(0)... [Failed]

Usage with CFLAGS

/tests/driver_mma8x5x/Makefile

CFLAGS += -DCONFIG_MMA8X5X_I2C_ADDRESS=0x1C

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-159-ge836e-Kconfig_mma8x5x)
CONFIG_MMA8X5X_I2C_ADDRESS=0x1C
MMA8652 accelerometer driver test application

Initializing MMA8652 accelerometer at I2C_DEV(0)... [Failed]

Usage with Kconfig

/tests/driver_mma8x5x/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-159-ge836e-Kconfig_mma8x5x)
CONFIG_MMA8X5X_I2C_ADDRESS=0x1C
MMA8652 accelerometer driver test application

Initializing MMA8652 accelerometer at I2C_DEV(0)... [Failed]

Note : The network device is not available fro interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

@akshaim
drivers/mma8x5x : Add CONFIG_
7e3096e 
Add CONFIG_ Prefix for CONFIG_MMA8X5X_I2C_ADDRESS
@akshaim
drivers/mma8x5x : Expose to Kconfig
ec98054 
Expose Configurations to Kconfig
leandrolanzieri
leandrolanzieri approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The configuration macro is generated correctly. ACK.

@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 23, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 23, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 23, 2020
Open
71 tasks
@leandrolanzieri leandrolanzieri merged commit c2c32a4 into RIOT-OS:master Apr 23, 2020
@akshaim akshaim deleted the Kconfig_mma8x5x branch May 4, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri