Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/motor_driver : Expose Configurations to Kconfig #13927

Merged
merged 2 commits into from
Apr 23, 2020
Merged

drivers/motor_driver : Expose Configurations to Kconfig #13927

merged 2 commits into from
Apr 23, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 22, 2020 •
edited
Loading

Contribution description

This PR exposes compile configurations in Motor Driver Actuator Device driver to Kconfig.

Testing procedure

New macro was introduced in main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Default State:

Firmware Output

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

Auto init xtimer.
main(): This is RIOT! (Version: 2020.07-devel-166-g1774d-Kconfig_motor_driver)
CONFIG_MOTOR_DRIVER_MAX=(2)
Brake motors !!!

Usage with CFLAGS

/tests/driver_motor_driver/Makefile

CFLAGS += -DCONFIG_MOTOR_DRIVER_MAX=4

Firmware Output

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

Auto init xtimer.
main(): This is RIOT! (Version: 2020.07-devel-166-g1774d-Kconfig_motor_driver)
CONFIG_MOTOR_DRIVER_MAX=4
Brake motors !!!

Usage with Kconfig

/tests/driver_motor_driver/

make menuconfig

Firmware Output

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

Auto init xtimer.
main(): This is RIOT! (Version: 2020.07-devel-166-g1774d-Kconfig_motor_driver)
CONFIG_MOTOR_DRIVER_MAX=6
Brake motors !!!

Note : The network device is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

leandrolanzieri
leandrolanzieri reviewed Apr 23, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments. You can squash directly

drivers/motor_driver/Kconfig Outdated Show resolved Hide resolved
drivers/motor_driver/Kconfig Outdated Show resolved Hide resolved
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 23, 2020
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 23, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 23, 2020
Open
71 tasks
akshaim and others added 2 commits April 23, 2020 15:21
@akshaim
drivers/motor_driver : Add CONFIG_
39826d6 
Add CONFIG_ Prefix for MOTOR_DRIVER_MAX
@akshaim @leandrolanzieri
drivers/motor_driver : Expose to Kconfig
c654b4e 
Expose Configurations to Kconfig

Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
@akshaim akshaim force-pushed the Kconfig_motor_driver branch from fe6cd29 to c654b4e Compare April 23, 2020 09:53
@akshaim
Copy link
Member Author

akshaim commented Apr 23, 2020

Just minor comments. You can squash directly

Done. Thanks

leandrolanzieri
leandrolanzieri approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 23, 2020
@leandrolanzieri leandrolanzieri merged commit 6ca6737 into RIOT-OS:master Apr 23, 2020
@akshaim akshaim deleted the Kconfig_motor_driver branch May 4, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri