Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/slipdev : Expose Configurations to Kconfig #13954

Merged
merged 2 commits into from
Apr 29, 2020
Merged

drivers/slipdev : Expose Configurations to Kconfig #13954

merged 2 commits into from
Apr 29, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 26, 2020

Contribution description

This PR exposes compile configurations in SLIPDEV Network driver to Kconfig.

Testing procedure

New folder (/tests/driver_slipdev) was added. New test file and Make file was introduced in tests/driver_slipdev/ for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was tested on native.

Default State:

Firmware Output

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-201-g2e015-Kconfig_slipdev_tests)
CONFIG_SLIPDEV_BUFSIZE=(2048U)

Usage with CFLAGS

/tests/driver_slipdev/Makefile

CFLAGS += -DCONFIG_SLIPDEV_BUFSIZE=128

Firmware Output

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-201-g2e015-Kconfig_slipdev_tests)
CONFIG_SLIPDEV_BUFSIZE=128

Usage with Kconfig

/tests/driver_slipdev/

make menuconfig

Firmware Output

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-201-g2e015-Kconfig_slipdev_tests)
CONFIG_SLIPDEV_BUFSIZE=4096

Issues/PRs references

#12888
@leandrolanzieri

@akshaim akshaim force-pushed the Kconfig_slipdev branch 2 times, most recently from 9ff41a9 to d094f35 Compare April 26, 2020 12:35
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 27, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 27, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 27, 2020
Open
71 tasks
@leandrolanzieri leandrolanzieri added the Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines label Apr 27, 2020
leandrolanzieri
leandrolanzieri reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Please address it and squash directly

drivers/include/slipdev.h Outdated Show resolved Hide resolved
akshaim added 2 commits April 29, 2020 09:42
@akshaim
drivers/slipdev : Add CONFIG_
b4451ff 
Add CONFIG_ prefix to SLIPDEV_BUFSIZE
@akshaim
drivers/slipdev : Expose to Kconfig
e6924e5 
Expose configurations to Kconfig
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 29, 2020
leandrolanzieri
leandrolanzieri approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Thanks for the contribution

@leandrolanzieri leandrolanzieri merged commit d822a91 into RIOT-OS:master Apr 29, 2020
@akshaim akshaim deleted the Kconfig_slipdev branch June 3, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri