Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/sps30 : Expose Configurations to Kconfig #13966

Merged
merged 2 commits into from
Apr 28, 2020
Merged

drivers/sps30 : Expose Configurations to Kconfig #13966

merged 2 commits into from
Apr 28, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 28, 2020

Contribution description

This PR exposes compile configurations in SPS30 Sensor Device driver to Kconfig.

Testing procedure

New macro was introduced in tests/driver_sps30/main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was uploaded to FIT IoT Lab test bed.

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-200-gea488-Kconfig_sps30_tests)
CONFIG_SPS30_ERROR_RETRY=(500U)
SPS30 test application

sps30_init: [I2C_ERROR]
sps30_read_article_code: [I2C_ERROR]
sps30_read_serial_number: [I2C_ERROR]
sps30_start_fan_clean: [I2C_ERROR]

Usage with CFLAGS

/tests/driver_sps30/Makefile

CFLAGS += -DCONFIG_SPS30_ERROR_RETRY=10

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-200-gea488-Kconfig_sps30_tests)
CONFIG_SPS30_ERROR_RETRY=10
SPS30 test application

sps30_init: [I2C_ERROR]
sps30_read_article_code: [I2C_ERROR]
sps30_read_serial_number: [I2C_ERROR]
sps30_start_fan_clean: [I2C_ERROR]

Usage with Kconfig

/tests/driver_sps30/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-200-gea488-Kconfig_sps30_tests)
CONFIG_SPS30_ERROR_RETRY=0
SPS30 test application

sps30_init: [I2C_ERROR]
sps30_read_article_code: [I2C_ERROR]
sps30_read_serial_number: [I2C_ERROR]
sps30_start_fan_clean: [I2C_ERROR]

Note : The sensor is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 28, 2020
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 28, 2020
leandrolanzieri
leandrolanzieri reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please rebase

akshaim added 2 commits April 28, 2020 20:10
@akshaim
drivers/sps30 : Add CONFIG_
819a36d 
Add CONFIG_ prefix to SPS30_ERROR_RETRY
@akshaim
drivers/sps30 : Expose to Kconfig
817370c 
Expose configurations to Kconfig
@akshaim
Copy link
Member Author

akshaim commented Apr 28, 2020

Looks good. Please rebase

Done.

@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 28, 2020
leandrolanzieri
leandrolanzieri approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 28, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 28, 2020
Open
71 tasks
@leandrolanzieri leandrolanzieri merged commit bb66845 into RIOT-OS:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri