Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/tcs37727 : Expose Configurations to Kconfig #13980

Merged
merged 2 commits into from
May 8, 2020
Merged

drivers/tcs37727 : Expose Configurations to Kconfig #13980

merged 2 commits into from
May 8, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 29, 2020

Contribution description

This PR exposes compile configurations in TCS37727 Sensor Device driver to Kconfig.

Testing procedure

  1. New documentation was built using doxygen

The build worked fine.

  1. New macro was introduced in tests/driver_tcs37727/main.c for testing.
#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was uploaded to FIT IoT Lab test bed.

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-246-g68166-Kconfig_tcs37727_tests)
CONFIG_TCS37727_ATIME_DEFAULT=200000
TCS37727 RGBC Data; Sensor driver test application

Initializing first configured TCS37727 sensor...[tcs37727] init: error while reading ID register
[Failed]

Usage with CFLAGS

/tests/driver_tcs37727/Makefile

CFLAGS += -DCONFIG_TCS37727_ATIME_DEFAULT=15000

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-246-g68166-Kconfig_tcs37727_tests)
CONFIG_TCS37727_ATIME_DEFAULT=15000
TCS37727 RGBC Data; Sensor driver test application

Initializing first configured TCS37727 sensor...[tcs37727] init: error while reading ID register
[Failed]

Usage with Kconfig

/tests/driver_tcs37727/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-246-g68166-Kconfig_tcs37727_tests)
CONFIG_TCS37727_ATIME_DEFAULT=250000
TCS37727 RGBC Data; Sensor driver test application

Initializing first configured TCS37727 sensor...[tcs37727] init: error while reading ID register
[Failed]

Note : The sensor is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels May 4, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone May 4, 2020
leandrolanzieri
leandrolanzieri reviewed May 4, 2020
View reviewed changes
drivers/include/tcs37727.h Outdated Show resolved Hide resolved
drivers/tcs37727/Kconfig Outdated Show resolved Hide resolved
@leandrolanzieri leandrolanzieri mentioned this pull request May 4, 2020
Open
71 tasks
@leandrolanzieri
Copy link
Contributor

Please rebase

@akshaim
drivers/tcs37727 : Add CONFIG_
04bdd40 
Add CONFIG_ prefix to TCS37727_ATIME_DEFAULT and update
documentation for doxygen.
@akshaim akshaim force-pushed the Kconfig_tcs37727 branch from e42fa3f to 8b38e02 Compare May 7, 2020 17:52
@akshaim @leandrolanzieri
drivers/tcs37727 : Expose to Kconfig
b4a23b8 
Co-authored-by: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
@akshaim akshaim force-pushed the Kconfig_tcs37727 branch from 8b38e02 to b4a23b8 Compare May 7, 2020 18:25
@akshaim
Copy link
Member Author

akshaim commented May 7, 2020

Please rebase

Done. Thanks for the review.

leandrolanzieri
leandrolanzieri approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Configuration option shows up ok, and the macro is generated correctly. ACK.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 8, 2020
@leandrolanzieri leandrolanzieri merged commit e272cc9 into RIOT-OS:master May 8, 2020
@akshaim akshaim deleted the Kconfig_tcs37727 branch June 3, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri