Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/ bmx055 : Expose Configurations to Kconfig #13998

Merged
merged 2 commits into from
May 4, 2020
Merged

drivers/ bmx055 : Expose Configurations to Kconfig #13998

merged 2 commits into from
May 4, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented May 1, 2020

Contribution description

This PR exposes compile configurations in BMX055 Sensor Device driver to Kconfig.

Testing procedure

  1. New documentation was built using doxygen

The build works fine.

  1. Header was introduced in tests/driver_bmx055/main.c for testing.
    #include "bmx055.h"

  2. New macro was introduced in tests/driver_bmx055/main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was uploaded to FIT IoT Lab test bed.

Default State:

Firmware Output

[auto_init_saul] error initializing bmx055 #0
main(): This is RIOT! (Version: 2020.07-devel-312-g404ed-Kconfig_bmx055_tests)
CONFIG_BMX055_MAG_ADDR_DEFAULT=(0x10U)
CONFIG_BMX055_ACC_ADDR_DEFAULT=(0x18U)
CONFIG_BMX055_GYRO_ADDR_DEFAULT=(0x68U)
Test application for bmx055 module

Dev: LED(orange) Type: ACT_SWITCH
Data: 0

Dev: Button(SW0) Type: SENSE_BTN
Data: 0

Usage with CFLAGS

/tests/driver_bmx055/Makefile

CFLAGS += -DCONFIG_BMX055_MAG_ADDR_DEFAULT=0x11
CFLAGS += -DCONFIG_BMX055_ACC_ADDR_DEFAULT=0x19
CFLAGS += -DCONFIG_BMX055_GYRO_ADDR_DEFAULT=0x69

Firmware Output

[auto_init_saul] error initializing bmx055 #0
main(): This is RIOT! (Version: 2020.07-devel-312-g404ed-Kconfig_bmx055_tests)
CONFIG_BMX055_MAG_ADDR_DEFAULT=0x11
CONFIG_BMX055_ACC_ADDR_DEFAULT=0x19
CONFIG_BMX055_GYRO_ADDR_DEFAULT=0x69
Test application for bmx055 module

Dev: LED(orange) Type: ACT_SWITCH
Data: 0

Dev: Button(SW0) Type: SENSE_BTN
Data: 0

Usage with Kconfig

/tests/driver_bmx055/

make menuconfig

Firmware Output

[auto_init_saul] error initializing bmx055 #0
main(): This is RIOT! (Version: 2020.07-devel-312-g404ed-Kconfig_bmx055_tests)
CONFIG_BMX055_MAG_ADDR_DEFAULT=0x13
CONFIG_BMX055_ACC_ADDR_DEFAULT=0x19
CONFIG_BMX055_GYRO_ADDR_DEFAULT=0x69
Test application for bmx055 module

Dev: LED(orange) Type: ACT_SWITCH
Data: 0

Dev: Button(SW0) Type: SENSE_BTN
Data: 0

Note : The sensor is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri Please merge this only after #13981

@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels May 4, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone May 4, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request May 4, 2020
Open
71 tasks
@leandrolanzieri leandrolanzieri added State: waiting for other PR State: The PR requires another PR to be merged first and removed State: waiting for other PR State: The PR requires another PR to be merged first labels May 4, 2020
@leandrolanzieri
Copy link
Contributor

Please rebase

@akshaim
drivers/bmx055 : Add CONFIG_
211b86c 
Add CONFIG_ prefix to compile configurations
@akshaim
Copy link
Member Author

akshaim commented May 4, 2020

Please rebase

Done.

@akshaim
drivers/bmx055 : Expose to Kconfig
9ef4f30 
Expose configurations to Kconfig
leandrolanzieri
leandrolanzieri approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kconfig defaults yield the same as the current macros. Changes in menuconfig reflect in the configuration macros. ACK.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 4, 2020
@leandrolanzieri leandrolanzieri merged commit 39421e6 into RIOT-OS:master May 4, 2020
@akshaim akshaim deleted the Kconfig_bmx055 branch May 5, 2020 04:09
@akshaim
Copy link
Member Author

akshaim commented May 5, 2020

Kconfig defaults yield the same as the current macros. Changes in menuconfig reflect in the configuration macros. ACK.

Thnak you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri