Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/l2filter : Expose configurations to Kconfig #14567

Merged
merged 4 commits into from
Jul 22, 2020
Merged

net/l2filter : Expose configurations to Kconfig #14567

merged 4 commits into from
Jul 22, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Jul 21, 2020

Contribution description

This PR exposes compile configurations in net/l2filter to Kconfig.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were added to tests/net_l2filter/

    The test file can be found here

    Compiled binaries for native

Default State:

Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-293-g96fa2-Kconfig_l2filter_tests)
CONFIG_L2FILTER_ADDR_MAXLEN=(8U)
CONFIG_L2FILTER_LISTSIZE=(8U)

Usage with CFLAGS :

CFLAGS += -DCONFIG_L2FILTER_ADDR_MAXLEN=6
CFLAGS += -DCONFIG_L2FILTER_LISTSIZE=6
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-293-g96fa2-Kconfig_l2filter_tests)
CONFIG_L2FILTER_ADDR_MAXLEN=6
CONFIG_L2FILTER_LISTSIZE=6

Usage with menuconfig :

make menuconfig

Default values

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-293-g96fa2-Kconfig_l2filter_tests)
CONFIG_L2FILTER_ADDR_MAXLEN=8
CONFIG_L2FILTER_LISTSIZE=8
Macros Configured output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-293-g96fa2-Kconfig_l2filter_tests)
CONFIG_L2FILTER_ADDR_MAXLEN=10
CONFIG_L2FILTER_LISTSIZE=10

MACROS were successfully configured.

Issues/PRs references

#12888

@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jul 21, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 21, 2020
leandrolanzieri
leandrolanzieri reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor nits.

sys/include/net/l2filter.h Outdated Show resolved Hide resolved
drivers/include/net/netdev.h Show resolved Hide resolved
sys/net/link_layer/l2filter/Kconfig Outdated Show resolved Hide resolved
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels Jul 21, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Jul 21, 2020
Open
71 tasks
@leandrolanzieri
Copy link
Contributor

Please squash @akshaim

@akshaim akshaim force-pushed the Kconfig_l2filter branch from 1ab7b0f to 6017097 Compare July 21, 2020 18:56
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jul 22, 2020
leandrolanzieri
leandrolanzieri approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@leandrolanzieri leandrolanzieri merged commit 2572326 into RIOT-OS:master Jul 22, 2020
@akshaim
Copy link
Member Author

akshaim commented Jul 22, 2020

ACK!

Thanks @leandrolanzieri for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri