Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/skald: Expose configurations to Kconfig #14824

Merged
merged 4 commits into from
Aug 26, 2020
Merged

net/skald: Expose configurations to Kconfig #14824

merged 4 commits into from
Aug 26, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Aug 21, 2020 •
edited
Loading

Contribution description

This PR exposes compile configurations in net/skald to Kconfig.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were added to tests/net_skald/

    The test branch can be found here

    Compiled binaries for nrf52dk

Default State:

Firmware Output
main(): This is RIOT! (Version: 2020.10-devel-891-g1d136-Kconfig_skald_tests)
CONFIG_SKALD_INTERVAL=1500000
2
37
38

Usage with CFLAGS :

CFLAGS += -DCONFIG_SKALD_INTERVAL_S=1
CFLAGS += -DSKALD_ADV_CHAN={37,38}
Firmware Output
main(): This is RIOT! (Version: 2020.10-devel-891-g4038e-Kconfig_skald_tests)
SKALD_INTERVAL=1 * (1000000LU)
2
37
38

Usage with menuconfig :

make menuconfig

Default values

main(): This is RIOT! (Version: 2020.10-devel-891-g1d136-Kconfig_skald_tests)
CONFIG_SKALD_INTERVAL=1000000
3
37
38
39
Macros Configured output
main(): This is RIOT! (Version: 2020.10-devel-891-g1d136-Kconfig_skald_tests)
CONFIG_SKALD_INTERVAL=1600000
1
38

MACROS were successfully configured.

Issues/PRs references

#12888

@leandrolanzieri leandrolanzieri changed the title net/skald : : Expose configurations to Kconfig net/skald: Expose configurations to Kconfig Aug 21, 2020
@leandrolanzieri leandrolanzieri added Area: BLE Area: Bluetooth Low Energy support Area: Kconfig Area: Kconfig integration Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Aug 21, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Aug 21, 2020
Open
71 tasks
leandrolanzieri
leandrolanzieri reviewed Aug 24, 2020
View reviewed changes
sys/include/net/skald.h Outdated Show resolved Hide resolved
sys/net/ble/skald/Kconfig Outdated Show resolved Hide resolved
@leandrolanzieri
Copy link
Contributor

Looks good, please squash @akshaim

@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Aug 26, 2020
akshaim added 4 commits August 26, 2020 15:12
@akshaim
net/skald : Move 'SKALD_INTERVAL' to 'CONFIG_'
4219036
@akshaim
net/skald : Enable configuration of 'SKALD_ADV_CHAN'
b210da4 
Add macros to disable specific channels and move macros to
'CONFIG_' namespace
@akshaim
net/skald : Expose to Kconfig
112514a 
Expose configurations to Kconfig
@akshaim
net/skald : Update documentation
32af195 
Add documentation and checks for 'DOXYGEN' defines to better
render documentation.
@akshaim
Copy link
Member Author

akshaim commented Aug 26, 2020

Looks good, please squash @akshaim

Done.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Aug 26, 2020
@leandrolanzieri leandrolanzieri added the Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines label Aug 26, 2020
leandrolanzieri
leandrolanzieri approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@leandrolanzieri leandrolanzieri merged commit ec7afef into RIOT-OS:master Aug 26, 2020
This was referenced Jan 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: BLE Area: Bluetooth Low Energy support Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri