Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_sock_ip: fix NULL pointer dereference #14963

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Sep 7, 2020

Contribution description

See #5772 (comment)

Testing procedure

Run tests/gnrc_sock_ip. Without the fix in b187917 the test will crash with a segfault. With the fix it will pass.

Issues/PRs references

#5772 (review)

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 7, 2020
@miri64 miri64 added this to the Release 2020.10 milestone Sep 7, 2020
@miri64 miri64 requested a review from keestux September 7, 2020 07:19
@benpicco
Copy link
Contributor

benpicco commented Sep 7, 2020

Looks like 01-run.py needs an update.

Copy link
Contributor

@keestux keestux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aabadie
Copy link
Contributor

aabadie commented Sep 8, 2020

@miri64 miri64 force-pushed the gnrc_sock_ip/fix/sock branch from b187917 to 7d47484 Compare September 8, 2020 11:05
@miri64
Copy link
Member Author

miri64 commented Sep 8, 2020

Addressed and squashed

@miri64 miri64 added Area: network Area: Networking and removed Area: network Area: Networking labels Sep 8, 2020
@miri64 miri64 merged commit ec436b9 into RIOT-OS:master Sep 8, 2020
@miri64 miri64 deleted the gnrc_sock_ip/fix/sock branch September 8, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants