Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/tinydtls: remove deprecation message about some CFLAGS #15344

Merged
merged 1 commit into from
Oct 30, 2020
Merged

pkg/tinydtls: remove deprecation message about some CFLAGS #15344

merged 1 commit into from
Oct 30, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Oct 30, 2020

Contribution description

This PR removes 3 deprecation messages in the tinydtls package. These messages are about the DTLS_DEBUG, DTLS_PSK and DTLS_ECC configuration options that were replaced by CONFIG_DTLS_DEBUG, CONFIG_DTLS_PSK and CONFIG_DTLS_ECC, respectively.

The replacement of these defines in the code was already done in #12992.

Testing procedure

  • A green Murdock

Issues/PRs references

Follow-up of #12992

@aabadie aabadie added Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 30, 2020
leandrolanzieri
leandrolanzieri approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation period is over, so the messages are not longer needed. ACK!

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels Oct 30, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2021.01 milestone Oct 30, 2020
@leandrolanzieri leandrolanzieri merged commit 4021b10 into RIOT-OS:master Oct 30, 2020
@aabadie aabadie deleted the pr/pkg/tinydtls_remove_deprecated_cflags branch October 30, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.01
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @leandrolanzieri