Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/trace: use raw strings in expect regexp #15370

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 3, 2020

Contribution description

This PR cleans up the Python automated test script of the tests/trace application: regexp string should be marked as raw string to avoid the following flake8 errors:

tests/sys/trace/tests/01-run.py:8:28: W605 invalid escape sequence '\ '
tests/sys/trace/tests/01-run.py:8:31: W605 invalid escape sequence '\d'
tests/sys/trace/tests/01-run.py:9:28: W605 invalid escape sequence '\+'
tests/sys/trace/tests/01-run.py:9:30: W605 invalid escape sequence '\ '
tests/sys/trace/tests/01-run.py:9:33: W605 invalid escape sequence '\d'

Testing procedure

  • A green CI
  • make -C tests/trace all test is successful:
$ make -C tests/trace all test --no-print-directory 
Building application "tests_trace" for "native" with MCU "native".

"make" -C /work/riot/RIOT/boards/native
"make" -C /work/riot/RIOT/boards/native/drivers
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/cpu/native
"make" -C /work/riot/RIOT/cpu/native/periph
"make" -C /work/riot/RIOT/cpu/native/stdio_native
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/div
"make" -C /work/riot/RIOT/sys/test_utils/interactive_sync
"make" -C /work/riot/RIOT/sys/trace
"make" -C /work/riot/RIOT/sys/xtimer
/usr/bin/ld: /work/riot/RIOT/tests/trace/bin/native/cpu/tramp.o: warning: relocation against `_native_saved_eip' in read-only section `.text'
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
   text	   data	    bss	    dec	    hex	filename
  32670	    596	  48380	  81646	  13eee	/work/riot/RIOT/tests/trace/bin/native/tests_trace.elf
r
/work/riot/RIOT/tests/trace/bin/native/tests_trace.elf  
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2021.01-devel-568-gef871-pr/tests/trace_script_cleanup)
n=   0 t=  3056935 v=0x00000000
n=   1 t=+       3 v=0x00000001

Issues/PRs references

Raised when running the static test locally in #15358

@aabadie aabadie added Area: tests Area: tests and testing framework Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Nov 3, 2020
@aabadie aabadie requested a review from miri64 as a code owner November 3, 2020 13:50
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Completely agree.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 3, 2020
@aabadie aabadie merged commit a9389e0 into RIOT-OS:master Nov 3, 2020
@aabadie aabadie deleted the pr/tests/trace_script_cleanup branch November 3, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants