Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/driver_bme680: improve automated test script #15372

Merged
merged 2 commits into from
Nov 4, 2020
Merged

tests/driver_bme680: improve automated test script #15372

merged 2 commits into from
Nov 4, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 3, 2020

Contribution description

This PR improves the automated test script of tests/driver_bme680 and also provides a minor enhancement of the test application (exit if driver initialization fails).

Otherwise flake8 raises:

tests/drivers/bme680/tests/01-run.py:19:19: W605 invalid escape sequence '\['
tests/drivers/bme680/tests/01-run.py:19:27: W605 invalid escape sequence '\]'

Testing procedure

  • A green Murdock
  • Check the test script is still working. This is difficult without the hardware. I don't have it but to test the regexp, I modified the test application to print fake values before the driver initialization. The version of this PR should work.

Issues/PRs references

Raised when running the static test locally in #15358

@aabadie aabadie added Area: tests Area: tests and testing framework Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 3, 2020
fjmolinas
fjmolinas approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit 0f0666e into RIOT-OS:master Nov 4, 2020
@aabadie aabadie deleted the pr/tests/driver_bme680_script_enh branch November 4, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @fjmolinas