Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/native: remove unused can_linux module #15407

Merged

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

b4f2903 adapted the can_linux module to the periph_can interface. This is a cleanup of some things that stayed behind. Here the makefile is removed, the references to can_linux in the dependency resolution and configuration Makefile are changed to the standard periph_can, and the startup code is adapted.

Testing procedure

  • test/candev when using periph_can should still work on native (I'm not able to test this locally)

Issues/PRs references

Module modified in #14909

@leandrolanzieri leandrolanzieri added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: cpu Area: CPU/MCU ports labels Nov 9, 2020
cpu/native/periph/can.c Outdated Show resolved Hide resolved
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense. ACK, please squash!

b4f2903 adapted the can_linux module to
the periph_can interface. This is a cleanup of some things that stayed
behind. Here the makefile is removed, the references to can_linux in the
dependency resolution and configuration Makefile are changed to the
standard periph_can, and the startup code is adapted.
@leandrolanzieri leandrolanzieri force-pushed the pr/native/periph/remove_unused_can branch from 7bfd9fc to d4be753 Compare November 13, 2020 08:13
Copy link
Member

@vincent-d vincent-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK

Thanks @leandrolanzieri

@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 13, 2020
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2020
@aabadie aabadie merged commit d91a135 into RIOT-OS:master Nov 13, 2020
@leandrolanzieri leandrolanzieri deleted the pr/native/periph/remove_unused_can branch November 13, 2020 10:29
@leandrolanzieri
Copy link
Contributor Author

Thanks everyone for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants