Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/ili9341 : Expose configurations to Kconfig #15547

Merged
merged 6 commits into from
Dec 7, 2020
Merged

drivers/ili9341 : Expose configurations to Kconfig #15547

merged 6 commits into from
Dec 7, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Dec 2, 2020 •
edited
Loading

Contribution description -

This PR exposes compile configurations in drivers/ili9341 to Kconfig.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were updated in tests/driver_ili9341

    The test file can be found here

    Compiled binaries for b-l072z-lrwan1 and tested on the evaluation board.

Default State:

Firmware Output
# main(): This is RIOT! (Version: 2021.01-devel-1336-g404dc7-Kconfig_driver_ili9341_tests)
# CONFIG_ILI9341_GVDD=4800
# CONFIG_ILI9341_VCOMH=4250
# CONFIG_ILI9341_VCOML=-2000
# CONFIG_ILI9341_LE_MODE=1

Usage with menuconfig :

make menuconfig

Default Firmware Output
main(): This is RIOT! (Version: 2021.01-devel-1336-gbfd28-Kconfig_driver_ili9341_tests)
CONFIG_ILI9341_GVDD=4800
CONFIG_ILI9341_VCOMH=4250
CONFIG_ILI9341_VCOML=-2000
CONFIG_ILI9341_LE_MODE=CONFIG_ILI9341_LE_MODE
Configured Firmware Output
main(): This is RIOT! (Version: 2021.01-devel-1336-gbfd28-Kconfig_driver_ili9341_tests)
CONFIG_ILI9341_GVDD=4700
CONFIG_ILI9341_VCOMH=4200
CONFIG_ILI9341_VCOML=-1000
CONFIG_ILI9341_LE_MODE=1

MACROS were successfully configured.

Issues/PRs references

#12888

@akshaim akshaim marked this pull request as ready for review December 2, 2020 16:38
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Dec 3, 2020
leandrolanzieri
leandrolanzieri reviewed Dec 3, 2020
View reviewed changes
drivers/ili9341/ili9341.c Outdated Show resolved Hide resolved
drivers/ili9341/Kconfig Outdated Show resolved Hide resolved
drivers/ili9341/Kconfig Outdated Show resolved Hide resolved
drivers/include/ili9341.h Outdated Show resolved Hide resolved
@leandrolanzieri
Copy link
Contributor

Looks good. Please squash @akshaim

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Dec 3, 2020
@akshaim akshaim force-pushed the Kconfig_driver_ili9341 branch from 0fe4445 to d65a4b3 Compare December 3, 2020 13:20
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels Dec 4, 2020
leandrolanzieri
leandrolanzieri approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@leandrolanzieri leandrolanzieri added this to the Release 2021.01 milestone Dec 7, 2020
@leandrolanzieri leandrolanzieri merged commit f74cb05 into RIOT-OS:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.01
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri