Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/telnet_server: add support for LWIP #17899

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Apr 3, 2022

Contribution description

Just enables the telnet example to be build with LWIP.

Testing procedure

Just build the examples/telnet_server with LWIP=1

Output is a bit broken compared to GNRC:

% telnet fe80:0:0:0:7837:fcff:fe7d:1aaf%tapbr0
Trying fe80::7837:fcff:fe7d:1aaf%tapbr0...
Connected to fe80:0:0:0:7837:fcff:fe7d:1aaf%tapbr0.
Escape character is '^]'.
RIOT telnet example application╔═══════════════════════════════════════════════════╗║telnet is entirely unencrypted and unauthenticated.║║Do not use this on public networks.                ║╚═══════════════════════════════════════════════════╝ps
  
p
s


	pid | name                 | state    Q | pri | stack  ( used) ( free) | base addr  | current     

	  - | isr_stack            | -        - |   - |   8192 (   -1) ( 8193) |  0x8084880 |  0x8084880

	  1 | idle                 | pending  Q |  15 |   8192 ( 1084) ( 7108) |  0x807d180 |  0x807efe0 

	  2 | main                 | running  Q |   7 |  12288 ( 3004) ( 9284) |  0x807f180 |  0x8081fe0 
	  3 | lwip_netdev_mux      | bl rx    _ |   3 |   8192 ( 1264) ( 6928) |  0x808d0a0 |  0x808ef00 
	  4 | tcpip_thread         | bl mbox  _ |   1 |   8192 ( 1756) ( 6436) |  0x8088d38 |  0x808ab98 
	  5 | telnet               | sleeping _ |   6 |   8192 ( 2580) ( 5612) |  0x808f820 |  0x8091680 
	    | SUM                  |            |     |  53248 ( 9688) (43560)
> 
> 
  >> 

which hints at some inconsistency on how the two TCP stacks are integrated.

Issues/PRs references

@github-actions github-actions bot added the Area: examples Area: Example Applications label Apr 3, 2022
@benpicco benpicco added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Apr 3, 2022
@benpicco benpicco requested a review from miri64 April 11, 2022 12:44
@benpicco benpicco force-pushed the examples/telnet_server-lwip branch from f729bc2 to 3b94cab Compare May 10, 2022 10:51
@benpicco benpicco removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label May 10, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 18, 2022
@maribu
Copy link
Member

maribu commented May 20, 2022

Output is a bit broken compared to GNRC:

Huh? That sounds like data gets corrupted in transit. Maybe there is an off-by-one issue that the last byte of a chunk is not send?

@benpicco benpicco requested a review from kfessel May 24, 2022 09:05
@benpicco benpicco force-pushed the examples/telnet_server-lwip branch from 3b94cab to d6f2c88 Compare June 6, 2022 23:30
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Change is unscary and I trust your testing

@benpicco benpicco enabled auto-merge June 7, 2022 07:01
@benpicco benpicco merged commit 380144f into RIOT-OS:master Jun 7, 2022
@benpicco benpicco deleted the examples/telnet_server-lwip branch June 7, 2022 10:20
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants