Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/heap_cmd: fix test script #18634

Merged
merged 1 commit into from
Sep 23, 2022
Merged

tests/heap_cmd: fix test script #18634

merged 1 commit into from
Sep 23, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Sep 23, 2022

Contribution description

In c95e855 the shell output of the heap command was changed and no longer matched the expectation of the test script. This adapts the test to again match the output.

Testing procedure

$ make BOARD=nucleo-f767zi -C tests/heap_cmd flash test
make: Entering directory '/home/maribu/Repos/software/RIOT/tests/heap_cmd'
Building application "tests_heap_cmd" for "nucleo-f767zi" with MCU "stm32".
[...]
   text	  data	   bss	   dec	   hex	filename
  16016	   132	  2424	 18572	  488c	/home/maribu/Repos/software/RIOT/tests/heap_cmd/bin/nucleo-f767zi/tests_heap_cmd.elf
/home/maribu/Repos/software/RIOT/dist/tools/openocd/openocd.sh flash /home/maribu/Repos/software/RIOT/tests/heap_cmd/bin/nucleo-f767zi/tests_heap_cmd.elf
[...]
Welcome to pyterm!
Type '/exit' to exit.

> heap

> heap
heap: 521732 (used 2500, free 519232) [bytes]
> malloc 100
malloc 100
allocated 0x200013c8
> heap
heap
heap: 521732 (used 2608, free 519124) [bytes]
free 0x200013c8
> free 0x200013c8
freeing 0x200013c8
> heap
heap
heap: 521732 (used 2500, free 519232) [bytes]

make: Leaving directory '/home/maribu/Repos/software/RIOT/tests/heap_cmd'

Issues/PRs references

#18355 (comment)

tests/heap_cmd: fix test script
466af04 
In c95e855 the shell output of the
heap command was changed and no longer matched the expectation of the
test script. This adapts the test to again match the output.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 23, 2022
@maribu maribu requested a review from kaspar030 September 23, 2022 12:49
@maribu maribu requested a review from miri64 as a code owner September 23, 2022 12:49
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Sep 23, 2022
@maribu maribu mentioned this pull request Sep 23, 2022
Merged
@benpicco benpicco merged commit d9e881e into RIOT-OS:master Sep 23, 2022
@maribu
Copy link
Member Author

maribu commented Sep 23, 2022

Thx :)

@maribu maribu deleted the tests/heap_cmd branch September 23, 2022 19:02
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
2 participants
@maribu @benpicco