Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_udp: use small stack-size #18709

Merged
merged 2 commits into from
Oct 28, 2022
Merged

gnrc_udp: use small stack-size #18709

merged 2 commits into from
Oct 28, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 7, 2022

Contribution description

I don't remember the stack for UDP ever being fuller than half full. So let's use half the stack size.

Testing procedure

Sending UDP packets should still work without crashes on all supported boards.

Issues/PRs references

Taken out of #18700 to discuss separately.

@miri64 miri64 requested a review from kaspar030 as a code owner October 7, 2022 13:54
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Oct 7, 2022
@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: network Area: Networking Area: sys Area: System and removed Area: network Area: Networking Area: tests Area: tests and testing framework Area: CI Area: Continuous Integration of RIOT components Area: sys Area: System Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 7, 2022
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 7, 2022
@riot-ci
Copy link

riot-ci commented Oct 7, 2022 •
edited
Loading

Murdock results

✔️ PASSED

f210bcc examples/gnrc_networking: adopt Makefile.ci for new RAM size

Success Failures Total Runtime
1996 0 1996 06m:44s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

benpicco
benpicco approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UDP thread hardly does anything

@miri64 miri64 force-pushed the gnrc_udp/enh/use-smaller-stack branch from 72bcda2 to f210bcc Compare October 27, 2022 15:28
@github-actions github-actions bot added the Area: examples Area: Example Applications label Oct 27, 2022
@miri64 miri64 merged commit 85cce1e into RIOT-OS:master Oct 28, 2022
@miri64 miri64 deleted the gnrc_udp/enh/use-smaller-stack branch October 28, 2022 09:52
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
5 participants
@miri64 @riot-ci @benpicco @aabadie @kaspar030