Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/shell: fix deprecated shell_command in examples and tests #18761

Merged
merged 3 commits into from
Oct 19, 2022
Merged

sys/shell: fix deprecated shell_command in examples and tests #18761

merged 3 commits into from
Oct 19, 2022

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

PR #18355 adds submodules for dedicated commands. However, there are few examples and tests, which still used deprecated modules:

  • examples/sniffer
  • tests/gcoap_fileserver
  • tests/nimble_esp_wifi_coexist

This PR changes configuration to use new submodules for dedicated commands.

Testing procedure

Without this PR during compilation makefile prints some warnings, respectively for listed programs:

Deprecated modules are in use: shell_commands
Deprecated modules are in use: md5sum shell_commands
Deprecated modules are in use: gnrc_udp_cmd shell_commands

With this PR this warnings are not presented. I tested first two programs with native board, and PR works. The last one uses xtensa-esp32-elf-gcc - tests are needed.

Issues/PRs references

PR #18355

@github-actions github-actions bot added Area: examples Area: Example Applications Area: tests Area: tests and testing framework labels Oct 18, 2022
@benpicco benpicco requested a review from maribu October 18, 2022 11:02
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 18, 2022
benpicco
benpicco approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup!

@riot-ci
Copy link

riot-ci commented Oct 18, 2022 •
edited
Loading

Murdock results

✔️ PASSED

7035c2c tests/nimble_esp_wifi_coexists: fix deprecated shell_commands

Success Failures Total Runtime
1987 0 1987 06m:30s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 18, 2022
@benpicco benpicco merged commit 1029660 into RIOT-OS:master Oct 19, 2022
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
5 participants
@krzysztof-cabaj @riot-ci @benpicco @maribu @kaspar030