sys/net: add Size1 and Size2 option numbers #18799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
approved these changes
Oct 25, 2022
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 7c3c466 sys/coap: add Size1 option number
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
kaspar030
added
CI: ready for build
benpicco
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR expands the
coap.hheader file with macro definitions for the Size2 and Size1 option numbers, making it a bit more convenient to use these two options. The PR does not contain any actual new logic, but it could be a first step for reviving #10169 and augmenting either nanocoap or gcoap.Testing procedure
Since there is no new logic introduced, comparing the numbers with the IANA registry and proofreading the documentation should suffice for this PR.
Issues/PRs references
—