tests: move core related applications to their own tests/core/ folder #19565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
the
Type: cleanup
aabadie
requested review from
miri64,
smlng,
leandrolanzieri,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: build system
aabadie
force-pushed
the
pr/tests/core_move
branch
from
b9b77bb to
e625b2e
Compare
aabadie
added
the
CI: ready for build
aabadie
force-pushed
the
pr/tests/core_move
branch
2 times, most recently
from
e786ce4 to
4bc73b7
Compare
maribu
approved these changes
May 10, 2023
There was a problem hiding this comment.
I wonder if the irq_cpp should rather be in a new tests/cpp (or maybe tests/cxx, as cpp could also mean c preprocessor).
But anyway, let's not have this discussion here. Once there is a tests/cxx folder, that could still be easily moved from tests/core to tests/cxx.
|
The cpp applications will be moved in |
|
bors merge |
|
Merge conflict. |
aabadie
force-pushed
the
pr/tests/core_move
branch
from
4bc73b7 to
cabe02c
Compare
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
May 10, 2023
19484: makefiles/arch/msp430.inc.mk: Fix compilation issues with GCC 12 r=maribu a=maribu
### Contribution description
This fixes the following compilation issues:
/home/maribu/Repos/software/RIOT/cpu/msp430fxyz/periph/gpio.c: In function 'gpio_periph_mode':
/home/maribu/Repos/software/RIOT/cpu/msp430fxyz/periph/gpio.c:95:15: error: array subscript 0 is outside array bounds of 'msp_port_isr_t[0]' [-Werror=array-bounds]
95 | sel = &(isrport->SEL);
| ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
by adding `CFLAGS += --param-min-pagesize=0` for GCC 12 (same issue as already fixed for AVR).
and:
/usr/lib/gcc/msp430-elf/12.2.0/../../../../msp430-elf/bin/ld: warning: /home/maribu/Repos/software/RIOT/cpu/msp430_common/ldscripts/xfa.ld contains output sections; did you forget -T?
by adding the missing `-T`.
### Testing procedure
The following should still work:
- `make BOARD=msb-430 -C examples/hello-world`
- `make BOARD=msb-430 -C tests/xfa flash test`
### Issues/PRs references
None
19565: tests: move core related applications to their own tests/core/ folder r=aabadie a=aabadie
19568: tests: move remaining driver related applications to tests/drivers r=aabadie a=aabadie
19575: treewide: fix format specifiers r=maribu a=maribu
### Contribution description
This brings format specifiers and the passed type back into sync. This won't change observable behavior in one case, and won't even change machine code in the other. But formally, this fixes bugs.
Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Co-authored-by: Alexandre Abadie <alexandre.abadie@inria.fr>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
May 10, 2023
19484: makefiles/arch/msp430.inc.mk: Fix compilation issues with GCC 12 r=maribu a=maribu
### Contribution description
This fixes the following compilation issues:
/home/maribu/Repos/software/RIOT/cpu/msp430fxyz/periph/gpio.c: In function 'gpio_periph_mode':
/home/maribu/Repos/software/RIOT/cpu/msp430fxyz/periph/gpio.c:95:15: error: array subscript 0 is outside array bounds of 'msp_port_isr_t[0]' [-Werror=array-bounds]
95 | sel = &(isrport->SEL);
| ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
by adding `CFLAGS += --param-min-pagesize=0` for GCC 12 (same issue as already fixed for AVR).
and:
/usr/lib/gcc/msp430-elf/12.2.0/../../../../msp430-elf/bin/ld: warning: /home/maribu/Repos/software/RIOT/cpu/msp430_common/ldscripts/xfa.ld contains output sections; did you forget -T?
by adding the missing `-T`.
### Testing procedure
The following should still work:
- `make BOARD=msb-430 -C examples/hello-world`
- `make BOARD=msb-430 -C tests/xfa flash test`
### Issues/PRs references
None
19565: tests: move core related applications to their own tests/core/ folder r=aabadie a=aabadie
Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Co-authored-by: Alexandre Abadie <alexandre.abadie@inria.fr>
|
Build failed (retrying...): |
|
Build failed: |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is similar as #19435, #19552, #19551 and #19564 but applied to core related test applications. There's no clear
core_naming scheme for these applications so maybe some were missed or added by mistake.Testing procedure
Issues/PRs references
#15358, #19435, #19552, #19551 and #19564