Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: mixed box of compilation fixes with clang #19634

Merged
merged 48 commits into from
Jul 18, 2023
Merged

tree-wide: mixed box of compilation fixes with clang #19634

merged 48 commits into from
Jul 18, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented May 19, 2023 •
edited
Loading

Contribution description

As the title says: This should increase the number of apps being able to build with clang quite a bit.

Testing procedure

  • no regressions
  • compiling with TOOLCHAIN=llvm should be less often result in frustration
    • Note: I guess this is at most half way towards getting everything building again with LLVM

Issues/PRs references

Depends on an includes:

Fixes: #18851

@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 19, 2023
@github-actions github-actions bot added Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … Platform: ARM Platform: This PR/issue effects ARM-based platforms labels May 19, 2023
@riot-ci
Copy link

riot-ci commented May 19, 2023 •
edited
Loading

Murdock results

✔️ PASSED

52cf2b4 .murdock: re-enable LLVM targets

Success Failures Total Runtime
7901 0 7901 12m:05s

Artifacts

@maribu maribu added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label May 20, 2023
@maribu maribu mentioned this pull request May 20, 2023
Merged
@github-actions github-actions bot added Area: BLE Area: Bluetooth Low Energy support Area: tools Area: Supplementary tools labels May 20, 2023
maribu and others added 20 commits July 18, 2023 12:24
@maribu
pkg/flatbuffers: disable building with LLVM toolchain
2c75acf
@maribu
pkg/libschc: fix compilation with clang
b8aec43
@maribu
pkg/libsocketcan: fix compilation with clang
4c94316
@maribu
pkg/lua: fix compilation with clang
180adc8
@maribu
pkg/lvgl: fix compilation with clang
777351e
@maribu
pkg/micro-ecc: blacklist LLVM
3586360 
LLVM was already blacklisted for some specific Cortex-M targets due
to register allocation failing. The issue now has spread. Rather than
starting a whack-a-mole game, let's disable LLVM altogether for that
package.
@maribu
pkg/micropython: fix compilation with clang
058150f
@maribu
pkg/nimble: fix compilation with LLVM
88648f5
@maribu
pkg/uwb-core: fix compilation with clang
a6571c1
@maribu
pkg/uwb-dw1000: fix compilation with clang
d2e04ed
@maribu
pkg/opendsme: fix compilation with LLVM
a95be63
@maribu
pkg/openthread: fix compilation with LLVM
855380e
@maribu
pkg/openwsn: fix compilation with clang
7752973
@maribu
pkg/wamr: blacklist LLVM
639690e
@maribu
pkg/relifx: fix compilation with clang
53b08d9
@maribu
pkg/tinyusb: fix compilation with clang
500b4eb
@maribu
pkg/tinyvcdiff: fix compilation with clang
78624a6
@maribu
pkg/u8g2: fix compilation with clang
3a3c09b
@maribu
pkg/utensor: fix compilation with clang++
2b6c6e6
@maribu
.murdock: re-enable LLVM targets
52cf2b4
@github-actions github-actions bot added the Area: doc Area: Documentation label Jul 18, 2023
@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit ceaf6bd into RIOT-OS:master Jul 18, 2023
@maribu maribu deleted the llvm-fixes branch July 18, 2023 15:31
@maribu
Copy link
Member Author

maribu commented Jul 18, 2023

Thx :)

@benpicco benpicco mentioned this pull request Sep 29, 2023
Merged
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
@Teufelchen1 Teufelchen1 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylad dylad dylad left review comments

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@Teufelchen1 Teufelchen1 Awaiting requested review from Teufelchen1

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@basilfx basilfx Awaiting requested review from basilfx basilfx is a code owner

@keestux keestux Awaiting requested review from keestux keestux is a code owner

@jue89 jue89 Awaiting requested review from jue89 jue89 is a code owner

Assignees
No one assigned
Labels
Area: BLE Area: Bluetooth Low Energy support Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: OTA Area: Over-the-air updates Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … Area: USB Area: Universal Serial Bus CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2023.10
Development

Successfully merging this pull request may close these issues.

Status on LLVM in RIOT / Examples
5 participants
@maribu @riot-ci @benpicco @dylad @MrKevinWeiss