boards: add ESP32-S3-USB-OTG support #19808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
github-actions
bot
added
Area: doc
gschorcht
added
Type: new feature
ST7735 driver can also be used for ST7789. st7789 is simply defined as pseudomodule that pulls in automatically module st7735.
gschorcht
force-pushed
the
boards/esp32s3-usb-otg
branch
from
edcfcae
to
2bf4155
Compare
benpicco
reviewed
Jul 7, 2023
gschorcht
force-pushed
the
boards/esp32s3-usb-otg
branch
from
51fd859
to
d2b9efd
Compare
|
There is still a fixup commit 👀 |
gschorcht
force-pushed
the
boards/esp32s3-usb-otg
branch
from
d2b9efd
to
d68c826
Compare
Yes, I had to fix a further Kconfig issue. |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides the support for the ESP32-S3-USB-OTG board.
The SD card can only be used in SPI mode at the moment. As soon as PR #19786 is merged, the SD/MMC support can be enabled and the SD card can then be used in SD mode with 4-bit data bus width.
The display uses uses the ST7789 driver IC that is compatible with the ST7735. For that purpose the ST7735 driver is extended by a pseudomodule definition
st7789for the ST7789 which is enabled by the board and enables automatically thest7789(e57c48a). Vise versa, board'sMakefile.depenables automatically thest7789pseudomodule if thest7735is used. The pseudomodulest7789is just used to increase the upper limit for supported lines. This change is also part of PR #19807.The PR includes a very small documentation fix for ESP32-S3-DevKit board that was noticed during the development of this board definition (1155b6a).Testing procedure
The board has been tested with all basic tests for supported hardware including
tests/driver/st3375:Issues/PRs references