Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/stm32l496g-disco: enable ST7789 display and touch panel #19938

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR enables the ST7789 display and the touch panel for the stm32l496g-disco.

The PR requires PR #19937.

Testing procedure

BOARD=stm32l496g-disco make -j8 -C tests/drivers/st77xx

should work.

Issues/PRs references

Depends on PR #19937

@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration labels Sep 21, 2023
@gschorcht gschorcht added Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first labels Sep 21, 2023
bors bot added a commit that referenced this pull request Sep 21, 2023
19937: drivers/lcd: add MCU 8080 16-bit parallel mode support r=benpicco a=gschorcht

### Contribution description

This PR adds the 16-bit support for MCU 8080 parallel mode for LCD driver ICs.

### Testing procedure

Use either PR #19938
```
BOARD=stm32l496g-disco make -j8 -C tests/drivers/st77xx
```
or #19939  on top of this PR to test.
```
BOARD=sstm32f723e-disco make -j8 -C tests/drivers/st77xx
```

### Issues/PRs references

Prerequisite for PR #19938 or PR #19938

Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Sep 21, 2023
@riot-ci
Copy link

riot-ci commented Sep 21, 2023

Murdock results

✔️ PASSED

fe06bf6 tests/drivers/st77xx: add stm32l496g-disco

Success Failures Total Runtime
565 0 565 03m:02s

Artifacts

@gschorcht gschorcht force-pushed the boards/stm32l496g-disco_enable_display branch from 38ed75b to 82be34c Compare September 22, 2023 05:34
@gschorcht
Copy link
Contributor Author

@benpicco The PR had to be rebased after merging PR #19937.

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just squash the Kconfig fix directly

@gschorcht gschorcht added the CI: ready for merge train 🚃 PR is ready to be merged and awaiting the next merge train label Sep 22, 2023
@gschorcht gschorcht force-pushed the boards/stm32l496g-disco_enable_display branch from e492a26 to fe06bf6 Compare September 22, 2023 10:20
@benpicco
Copy link
Contributor

bors merge

@gschorcht
Copy link
Contributor Author

Interesting, merging is blocked 🤔 and the CI compilation just took about 3 minutes.

@bors
Copy link
Contributor

bors bot commented Sep 22, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 348e253 into RIOT-OS:master Sep 22, 2023
23 checks passed
@gschorcht
Copy link
Contributor Author

Ok, merging was obviously delayed.

@gschorcht gschorcht deleted the boards/stm32l496g-disco_enable_display branch September 22, 2023 15:04
bors bot added a commit that referenced this pull request Oct 5, 2023
19941: drivers/lcd: add MCU-driven low-level parallel interface r=benpicco a=gschorcht

### Contribution description

The PR extends the LCD driver by a low-level interface for MCU-driven implementations of the MCU 8080 16-/8-bit parallel interface, allowing the MCU to use special peripherals for the interface, such as the FMC for STM32 MCUs, which is significantly faster than the integrated GPIO-driven parallel interface implementation of the LCD driver.

### Testing procedure

~Once PR #19938 and PR #19939 are merged, a PRs for these board can be pushed that allow to test this PR.~

Use either PR #19943 or PR #19944 on top of this PR to test, e.g. with PR #19943:
```
BOARD=stm32f723e-disco make -j8 -C tests/drivers/st77xx flash
```

### Issues/PRs references


Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: ready for merge train 🚃 PR is ready to be merged and awaiting the next merge train Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants