Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/stm32: uart: don't do DMA for small transfers #20230

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jan 4, 2024

Contribution description

For small transfers, setting up the DMA will take much longer than sending the bytes, so avoid doing DMA there to avoid a slowdown with DMA enabled.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers Area: cpu Area: CPU/MCU ports labels Jan 4, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 4, 2024
@riot-ci
Copy link

riot-ci commented Jan 4, 2024

Murdock results

✔️ PASSED

ca9bf1a cpu/stm32: uart: don't do DMA for small transfers

Success Failures Total Runtime
8101 0 8101 11m:28s

Artifacts

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are no benchmarks but it seems OK, it works the same on master, with and without periph_dma on the nucleo-f413zh.

@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Jan 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2024
@benpicco benpicco added this pull request to the merge queue Jan 18, 2024
Merged via the queue into RIOT-OS:master with commit d5f1fda Jan 18, 2024
27 checks passed
@benpicco benpicco deleted the CONFIG_UART_DMA_THRESHOLD_BYTES branch January 19, 2024 08:17
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants