-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/periph_gpio_ll: Implement API to switch direction #20292
Merged
benpicco
merged 4 commits into
RIOT-OS:master
from
maribu:drivers/periph/gpio_ll/switch_dir
Feb 5, 2024
Merged
drivers/periph_gpio_ll: Implement API to switch direction #20292
benpicco
merged 4 commits into
RIOT-OS:master
from
maribu:drivers/periph/gpio_ll/switch_dir
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
State: waiting for other PR
State: The PR requires another PR to be merged first
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Jan 23, 2024
maribu
requested review from
leandrolanzieri,
aabadie,
MichelRottleuthner,
MrKevinWeiss,
vincent-d,
benpicco,
dylad,
keestux,
gschorcht,
basilfx and
kYc0o
as code owners
January 23, 2024 20:05
github-actions
bot
added
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Area: doc
Area: Documentation
Area: tests
Area: tests and testing framework
Platform: AVR
Platform: This PR/issue effects AVR-based platforms
Area: drivers
Area: Device drivers
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
Area: cpu
Area: CPU/MCU ports
labels
Jan 23, 2024
maribu
changed the title
drivers/periph_gpio_ll: Implement API to swicht direction
drivers/periph_gpio_ll: Implement API to switch direction
Jan 24, 2024
2 tasks
maribu
force-pushed
the
drivers/periph/gpio_ll/switch_dir
branch
from
February 5, 2024 09:48
9337249
to
8abf4eb
Compare
github-actions
bot
removed
Area: doc
Area: Documentation
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
labels
Feb 5, 2024
maribu
added
Area: doc
Area: Documentation
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
and removed
State: waiting for other PR
State: The PR requires another PR to be merged first
labels
Feb 5, 2024
maribu
removed
Area: doc
Area: Documentation
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
labels
Feb 5, 2024
This adds two functions: void gpio_ll_switch_dir_output(gpio_port_t port, uword_t outputs); void gpio_ll_switch_dir_input(gpio_port_t port, uword_t inputs); The first configures GPIO pins specified by a bitmask as output, the second configures the specified pins as input. The main use case is to allow bit-banging bidirectional protocols using more basic GPIO peripherals that do not implement open drain mode, such as found e.g. on MSP430, ATmega, or SAM0. It is not intended to implement this feature on modern MCUs with sophisticated GPIO peripherals.
maribu
force-pushed
the
drivers/periph/gpio_ll/switch_dir
branch
from
February 5, 2024 09:56
8abf4eb
to
06a0537
Compare
benpicco
approved these changes
Feb 5, 2024
Thx :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: cpu
Area: CPU/MCU ports
Area: drivers
Area: Device drivers
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Platform: AVR
Platform: This PR/issue effects AVR-based platforms
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds two functions:
The first configures GPIO pins specified by a bitmask as output, the second configures the specified pins as input.
The main use case is to allow bit-banging bidirectional protocols using more basic GPIO peripherals that do not implement open drain mode, such as found e.g. on MSP430, ATmega, or SAM0.
It is not intended to implement this feature on modern MCUs with sophisticated GPIO peripherals.
This PR provides implementations for ATmega and SAM0, the only two GPIO peripherals currently supported by GPIO LL that lack open drain mode.
Testing procedure
The GPIO LL test was extended to also test for switching the direction, if supported.
make BOARD=samr21-xpro flash test-with-config -j
Issues/PRs references
Depends on and includes: #20290