core/lib/cib: add new functionality #20464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the doxygen comments to follow suggested practice of using retval.
This patch removes a superfluous init of the cib. The struct is already initialized by the test fixture's setup function.
github-actions
bot
added
Area: tests
Teufelchen1
reviewed
Mar 12, 2024
|
Doesn't touch any previous functionality, looks fine to me API wise, can go into |
maribu
approved these changes
Mar 18, 2024
maribu
reviewed
Mar 18, 2024
Comment on lines
+110
to
+111
| * @return index of next item | ||
| * @retval -1 if the buffer is empty |
There was a problem hiding this comment.
❤️ Thanks for also taking the time to improve the doc 😄
miri64
added
the
Process: needs >1 ACK
github-actions
bot
added
the
Process: missing approvals
This patch adds calls to be able to peek at items other than just the oldest item in a cib based FIFO. It also adds an "unsafe" peek to match the existing "unsafe" put and get functions.
|
fixup commits now squashed |
Teufelchen1
approved these changes
Mar 18, 2024
Teufelchen1
added
the
CI: ready for build
github-actions
bot
removed
the
Process: missing approvals
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This patch adds some more peek functions to
cib. It also makes some minor fixes to the existing unit tests and doc.Testing procedure
Issues/PRs references
none known