-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/sys/psa_crypto*: remove test symlinks #20545
tests/sys/psa_crypto*: remove test symlinks #20545
Conversation
There is also a label to disable the test cache if we need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up!
For some reason, Github doesn't let me comment on the lines directly, but in several main.c
files, you still have
/* Needed in case only hashes are tested */
(void)status;
(void)start;
which is now superfluous, right?
Maybe it would also be a good idea to add a comment to the example_*.c
files mentioning that they are copied from examples/psa_crypto
.
Apart from that, LGTM :)
You're right. I updated the files :) |
You may then squash everything together 👍 |
23da36a
to
2f98d21
Compare
2f98d21
to
a958332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
The PSA configuration tests used symlinks of the files from
examples/psa_crypto
.This lead to the issue that CI did not rebuild them for each of the tests and missed some boards with insufficient memories.
This PR removes the symlinks from the tests and cleans up some of the code.
Testing procedure
Run the tests successfully for all boards.