Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/net/application_layer/nanocoap: add nanocoap_sock_get_non() #20852

Merged
merged 3 commits into from
Sep 10, 2024
Merged

sys/net/application_layer/nanocoap: add nanocoap_sock_get_non() #20852

merged 3 commits into from
Sep 10, 2024

Conversation

fabian18
Copy link
Contributor

@fabian18 fabian18 commented Sep 5, 2024

Contribution description

We have NON-Confirmable versions for PUT, POST, and FETCH, but non for GET so far.
This PR adds it in a straight forward manner.

Testing procedure

tapsetup
Two native instances of tests/net/nanocoap_cli.
One starts the server:

2024-09-05 15:48:28,576 # server start
2024-09-05 15:48:28,576 # starting server on port 5683

The other one GETs a resource:

> get_non coap://[fe80::a0ae:a2ff:fe2f:af16]/value
2024-09-05 15:48:32,316 # get_non coap://[fe80::a0ae:a2ff:fe2f:af16]/value
2024-09-05 15:48:32,318 # 00000000  30

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: tests Area: tests and testing framework Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Sep 5, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 5, 2024
@riot-ci
Copy link

riot-ci commented Sep 5, 2024 •
edited
Loading

Murdock results

✔️ PASSED

02e513e sys/include/net: better documentation of nanocoap_sock_request_cb

Success Failures Total Runtime
10197 0 10197 15m:13s

Artifacts

@benpicco benpicco changed the title sys/net/application_layer/nanocoap: add `nanocoap_sock_get_non sys/net/application_layer/nanocoap: add nanocoap_sock_get_non() Sep 9, 2024
benpicco
benpicco approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to squash

@fabian18 fabian18 force-pushed the nanocoap_sock_get_non branch from e66f2b1 to be84af2 Compare September 10, 2024 07:24
@fabian18 fabian18 force-pushed the nanocoap_sock_get_non branch from be84af2 to 02e513e Compare September 10, 2024 14:47
@Teufelchen1 Teufelchen1 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into RIOT-OS:master with commit e31e814 Sep 10, 2024
25 checks passed
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
@fabian18 fabian18 deleted the nanocoap_sock_get_non branch January 11, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 left review comments

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabian18 @riot-ci @benpicco @Teufelchen1