-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: migrate to XFA SHELL_COMMAND #21171
Conversation
cc6a45f
to
483aa3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this one :) Thx!
Some comments inline. Feel free to squash at will and hit merge.
Oh, this one is interesting:
So using SHELL_COMMAND here would actually require changing the command name. I guess that would be fine for an example? |
Yes, it was brought up that |
fa755f0
to
8f5f268
Compare
Okay, changed the functions to static, changed the two shell command names, and squashed. Thanks for your review! |
Contribution description
Migrate all remaining examples to using the XFA SHELL_COMMAND instead of the statically allocated list (often with
extern
function declarations) inmain.c
.Testing procedure
CI should find bugs.