-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dist: added ng_sniffer script #2844
Conversation
What exactly did you change and why was it necessary? |
I think it's mostly that the syntax for setting channels and activating promiscuous mode has changed in the gnrc stack. |
that and also some code simplification and cleanup |
Actually, now that I think of it, we could actually merge both scripts. But since the older one is supposed to vanish (fingers crossed), we could save this work. |
sys.stderr.write('ifconfig 5 set promiscuous 1\n') | ||
serport.write('ifconfig 5 set raw 1\n') | ||
serport.write('ifconfig 5 set chan %s\n' % sys.argv[3]) | ||
serport.write('ifconfig 5 set promiscuous 1\n') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With modifications in RIOT-OS/applications#6 (comment) this is interface 4 now
A README, that this is to be used with RIOT-OS/applications#6 would be nice. |
512b25e
to
e3b4d30
Compare
updated the script to the new semantics of the |
@OlegHahm, @authmillenon, should I squash? |
|
||
## About | ||
|
||
This sniffer application can be used to sniff network traffic using RIOT based |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the application, but a script to use the application ;-)
@authmillenon: how about this description of the scripts parameters? |
``` | ||
$ ./ng_sniffer.py <tty> <baudrate> <channel> [outfile] | ||
``` | ||
The script needs the following parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"has" instead of "needs". outfile
seems to be optional.
ACK, please squash. |
squashed. |
Waiting for travis |
Static tests are passing, the others should not be touched by this: Go. |
I rewrote the sniffer script a little bit to work with the new network stack.
The script works together with the application proposed in RIOT-OS/applications#6