Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: added ng_sniffer script #2844

Merged
merged 1 commit into from
Jun 2, 2015
Merged

Conversation

haukepetersen
Copy link
Contributor

I rewrote the sniffer script a little bit to work with the new network stack.

The script works together with the application proposed in RIOT-OS/applications#6

@miri64
Copy link
Member

miri64 commented May 26, 2015

What exactly did you change and why was it necessary?

@OlegHahm
Copy link
Member

I think it's mostly that the syntax for setting channels and activating promiscuous mode has changed in the gnrc stack.

@haukepetersen
Copy link
Contributor Author

that and also some code simplification and cleanup

@OlegHahm
Copy link
Member

Actually, now that I think of it, we could actually merge both scripts. But since the older one is supposed to vanish (fingers crossed), we could save this work.

sys.stderr.write('ifconfig 5 set promiscuous 1\n')
serport.write('ifconfig 5 set raw 1\n')
serport.write('ifconfig 5 set chan %s\n' % sys.argv[3])
serport.write('ifconfig 5 set promiscuous 1\n')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With modifications in RIOT-OS/applications#6 (comment) this is interface 4 now

@miri64
Copy link
Member

miri64 commented May 27, 2015

A README, that this is to be used with RIOT-OS/applications#6 would be nice.

@haukepetersen haukepetersen force-pushed the ng_sniffer branch 2 times, most recently from 512b25e to e3b4d30 Compare May 28, 2015 15:47
@haukepetersen
Copy link
Contributor Author

updated the script to the new semantics of the ifconfig shell command and added a README. Say when I should squash.

@haukepetersen
Copy link
Contributor Author

@OlegHahm, @authmillenon, should I squash?


## About

This sniffer application can be used to sniff network traffic using RIOT based
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the application, but a script to use the application ;-)

@haukepetersen
Copy link
Contributor Author

@authmillenon: how about this description of the scripts parameters?

```
$ ./ng_sniffer.py <tty> <baudrate> <channel> [outfile]
```
The script needs the following parameters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"has" instead of "needs". outfile seems to be optional.

@miri64
Copy link
Member

miri64 commented Jun 2, 2015

ACK, please squash.

@haukepetersen
Copy link
Contributor Author

squashed.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 2, 2015
@miri64
Copy link
Member

miri64 commented Jun 2, 2015

Waiting for travis

@miri64
Copy link
Member

miri64 commented Jun 2, 2015

Static tests are passing, the others should not be touched by this: Go.

miri64 added a commit that referenced this pull request Jun 2, 2015
@miri64 miri64 merged commit 8498c93 into RIOT-OS:master Jun 2, 2015
@haukepetersen haukepetersen deleted the ng_sniffer branch June 2, 2015 13:11
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants