Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board/native: adapted Makefile.dep for netif init #3162

Merged
merged 3 commits into from
Jun 11, 2015
Merged

board/native: adapted Makefile.dep for netif init #3162

merged 3 commits into from
Jun 11, 2015

Conversation

haukepetersen
Copy link
Contributor

The new network stack does not now the concept of the defaulttransceiver, so this fix makes auto_init_ng_netif work for now.

@haukepetersen haukepetersen added Platform: native Platform: This PR/issue effects the native platform NSTF labels Jun 4, 2015
@haukepetersen haukepetersen added this to the Release 2015.06 milestone Jun 4, 2015
@haukepetersen haukepetersen mentioned this pull request Jun 4, 2015
Merged
@miri64
Copy link
Member

miri64 commented Jun 4, 2015

Is this only needed for native, or are the other boards elided for a different reason?

@haukepetersen
Copy link
Contributor Author

Actually, I have not looked at other boards (as the auto_init_ng_netif is working with all other boards)... So I guess native is the only board right now, that needs this fix.

@haukepetersen haukepetersen force-pushed the fix_native_netifinit branch from 8a8c1d5 to 389c687 Compare June 4, 2015 14:09
@haukepetersen
Copy link
Contributor Author

I updated it again slightly (and accidentally squashed already), now the Makefile has the identical structure of the Makefile.dep of the iot-lab and the samr21.

@miri64
Copy link
Member

miri64 commented Jun 4, 2015

Can't make line comments on mobile it seems so I have to comment here: Maybe out of scope of this PR, but I'm still opposed to using ng_netifas the signifier to include ng_nativenet (or some radio on other boards) et al. What if I just want to test netif using unittests? What if I implement some shiny new netapi-driven interface on native, like IP over raw sockets? What if I don't want to use nomac as the MAC layer? I prefer to keep the name defaulttransceiver or introduce a new defaultif pseudo module as a signifier for this behavior.

@haukepetersen
Copy link
Contributor Author

I actually agree, but I would like to continue this discussion somewhere else and merge this PR ASAP which then enables the merging of the ng_networking example which I want to get done quickly. Does this work for you?

@miri64
Copy link
Member

miri64 commented Jun 4, 2015

Yes, ACK

@LudwigKnuepfer LudwigKnuepfer added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 5, 2015
@haukepetersen haukepetersen force-pushed the fix_native_netifinit branch from 389c687 to dc42b5c Compare June 5, 2015 08:14
@haukepetersen
Copy link
Contributor Author

ups, there was a still a bug in Makefile.dep which lead to some failing builds for Travis. Its fixed now and I added a slight improvement for the error message that showed the bug.
@authmillenon, do you re-ack?

@miri64
Copy link
Member

miri64 commented Jun 5, 2015

Re-ACK

@miri64
Copy link
Member

miri64 commented Jun 5, 2015

Now we have we see the fruits of using ng_netif as the signifiers: unittests need the tap interface as an argument now -.-

@haukepetersen haukepetersen force-pushed the fix_native_netifinit branch from dc42b5c to ae25d12 Compare June 11, 2015 13:40
@haukepetersen
board/native: adapted Makefile.dep for netif init
235a488 
The new network stack does not now the concept of the
defaulttransceiver, so this fix makes auto_init_ng_netif
work for now.
@haukepetersen
cpu/native: improved error msg for netivenet
e32b6c9
@haukepetersen
make: added ng_netif_default as pseudomodule
ae25d12
@haukepetersen
Copy link
Contributor Author

To circumvent the problem above, I introduced a new pseudo-module called ng_netif_default. This is basically the same as the defaulttransceiver. I just did not like the old name, as this module can target more than 1 transceiver and it is also tied to the gnrc network stack, so I think something gnrc specific is a must.

miri64
miri64 reviewed Jun 11, 2015
View reviewed changes
boards/native/Makefile.dep
ifeq (,$(filter ng_netif,$(USEMODULE)))
USEMODULE += nativenet
USEMODULE += nativenet
ifeq (,$(filter netdev_base,$(USEMODULE)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's netdev_base?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it… a relic from when netdev was super complicated :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should know this... I just copied it from the Makefile.deps of the iot-lab and the samr21...

@haukepetersen haukepetersen mentioned this pull request Jun 11, 2015
Merged
@miri64
Copy link
Member

miri64 commented Jun 11, 2015

ACK

@miri64
Copy link
Member

miri64 commented Jun 11, 2015

&go

miri64 added a commit that referenced this pull request Jun 11, 2015
@miri64
Merge pull request #3162 from haukepetersen/fix_native_netifinit
1487b1c 
board/native: adapted Makefile.dep for netif init
@miri64 miri64 merged commit 1487b1c into RIOT-OS:master Jun 11, 2015
@haukepetersen haukepetersen deleted the fix_native_netifinit branch June 11, 2015 19:52
OlegHahm added a commit to OlegHahm/applications that referenced this pull request Aug 3, 2015
@OlegHahm
ng_sniffer: added ng_netif_default
04a972d 
This application was not adapted to
RIOT-OS/RIOT#3162 and
RIOT-OS/RIOT#3188
@OlegHahm OlegHahm mentioned this pull request Aug 3, 2015
Merged
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
chrysn pushed a commit to chrysn-pull-requests/RIOT that referenced this pull request Sep 20, 2022
@OlegHahm
ng_sniffer: added ng_netif_default
367f329 
This application was not adapted to
RIOT-OS#3162 and
RIOT-OS#3188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Milestone
Release 2015.09
Development

Successfully merging this pull request may close these issues.
3 participants
@haukepetersen @miri64 @LudwigKnuepfer