board/Nucleo-f303: initial support for the Nucleo-f303 #3165
Conversation
BytesGalore
changed the title
BytesGalore
added
Type: new feature
|
Congrats for your first PR :) |
| include $(RIOTBOARD)/Makefile.include.openocd | ||
|
|
||
| # include cortex defaults | ||
| include $(RIOTBOARD)/Makefile.include.cortexm_common |
| /** | ||
| * @name Define the nominal CPU core clock in this board | ||
| */ | ||
| #define F_CPU CLOCK_CORECLOCK |
There was a problem hiding this comment.
please add brackets (also for UART_0 and TIMER_0 below)
There was a problem hiding this comment.
ok forget this, it seems we never used brackets for these cases.
BytesGalore
added
the
CI: needs squashing
|
alright, the white-space warnings are history 👍 |
| * @{ | ||
| **/ | ||
| #define CLOCK_HSE (8000000U) /* external oscillator */ | ||
| #define CLOCK_CORECLOCK (72000000U) /* desired core clock frequency */ |
There was a problem hiding this comment.
the indention seems to be of by a few spaces here.
There was a problem hiding this comment.
less spaces or more for it to be on same collum as the other comments?
There was a problem hiding this comment.
I would put it to the same indention as the lines below.
|
Nice one! Except some minor style issues I think the PR looks good. Codewise you get my ack once the comments above are addressed. I don't have the board here, @BytesGalore and @PeterKietzmann, will you test it? Small thing when squashing: try to give your commits some good names. The convention used by most is something like |
| */ | ||
|
|
||
| #ifndef __PERIPH_CONF_H | ||
| #define __PERIPH_CONF_H |
There was a problem hiding this comment.
Change this include guard to PERIPH_CONF_H_ instead. Double underscores are reserved.
|
@katezilla, looks good :-) ! Congrats for your first PR. Please address the minor style comments and just ask if something is unclear. |
|
@katezilla thanks for the adaptions. Could you also address the newline-comments please? Otherwise we're not far from merging this PR :-) |
|
Sorry, now I see you already addressed the newline comments. Could you please add an I2C configuration to the periph_conf as a last step :-) ? |
|
@katezilla I tested I2C. For some reasons I2C_0 works and I2C_1 does not. Any ideas? Anyway, I think you can already squash your commits to one. I think your first commit message is fine. |
|
Does anyone have a stm32f3discovery board and can test the I2C_1 driver? |
|
@katezilla you defined pins |
|
I did the following measurement with the settings:
|
|
Just did. It's a bug in the frequency calculation of the f3 pwm driver -> unrelated to this PR. Lets just merge this board as is, but please open an issue so we can fix it afterwards for all f3 boards! |
|
ACK! I'll merge when Travis is green. Jippie! |
haukepetersen
removed
the
CI: needs squashing
|
removed squashing label and restarted Travis |
PeterKietzmann
added
the
CI: ready for build
|
The cortex-m4 build fails on the ported nucleo-f303 board for the both tests |
|
Just a thought: the build errors could be caused by missing gpio
definitions or similar. Check periph_conf.h
|
|
That would make sense cause the one test requires |
|
There is a blacklist feature in the application Makefile. I don't remember
the exact name, something like BLACKLIST_BOARDS, look around in the
Makefiles of other test applications for it.
|
|
Actually, the GPIO issue should be obsolete as #3095 is merged. To adapt this PR simply rebase this PR on master and remove the complete GPIO section from the |
|
@haukepetersen do I see it correctly that just the |
|
ACK and go. Will do a PR to remove the superfluous macro |
board/Nucleo-f303: initial support for the Nucleo-f303
|
Congrats for your first PR @katezilla! |
|
thx :) |
Add support for Nucleo-f303 (STM32f303)